Skip to content

Serial Support#337

Closed
Artucuno wants to merge 0 commit into
Baekalfen:serialfrom
Artucuno:serial
Closed

Serial Support#337
Artucuno wants to merge 0 commit into
Baekalfen:serialfrom
Artucuno:serial

Conversation

@Artucuno

@Artucuno Artucuno commented Aug 21, 2024

Copy link
Copy Markdown
Contributor
  • Merged changes from master branch
  • Working implementation of Serial

Tested in:

  • Pokemon Yellow
    • Trading
    • Battle

Issues:

  • There is a small issue where the emulator will temporarily freeze when waiting for the other Gameboy to respond to data (Should be an easy fix for someone) - Fixed in 7878718
  • Synchronization issues in some games, however Pokémon games work completely fine.
    • Tetris
  • When compiled into Cython, PyBoy freezes after socket connection is established

@Baekalfen

Copy link
Copy Markdown
Owner

Sorry, I rebased your branch so that it was in line with the history of master and serial. For some reason, GitHub thought it should close the PR on the force-push...

@Baekalfen

Copy link
Copy Markdown
Owner

You can pull the branch from here and reopen the PR https://github.com/Baekalfen/PyBoy/tree/artucuno/serial

@Artucuno

Artucuno commented Sep 8, 2024

Copy link
Copy Markdown
Contributor Author

No worries, I'll reopen the PR soon 👍

@Artucuno
Artucuno deleted the serial branch September 8, 2024 10:56
@Artucuno
Artucuno restored the serial branch September 8, 2024 10:56
@Artucuno
Artucuno deleted the serial branch September 8, 2024 10:56
This was referenced Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants