-
Notifications
You must be signed in to change notification settings - Fork 729
Tokens cleanup (D-E sets) #8046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7 u_2_1_a_phyrexian_myr @Daarken | ||
7 u_2_1_a_myr @Daarken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eradev the problem there is that there is no token script for u_2_1_a_myr anymore because it got updated to the phyrexian one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Maybe we should keep it as tokens don't get errata'd, even if it is not used anymore at the moment? M3C already has the updated token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then old LivingWeapon cards wouldn't find the old token anymore, for example
because then it would look for germ_phyrexian in old set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some testing but it should fallback to searching for that specific token if it isn't in the set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there is no problem on that front. You can try with Batterskull in NPH. It doesn't have a Germ token and it'll fetch the Phyrexian one without any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eradev how about "duplicate" the TokenScripts for this, so that both are defined like in the other MRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a Phyrexian Myr token printed in another set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still would prefer to keep it consistent with existing tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only duplicated them when existing tokens don't exist yet though (as in no printed version exist)? Otherwise I think it is better to have their correct printing to reflect their type and name correctly without having to double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tehdiplomat what do you think? should the old Images be duplicated for the new TokenScripts?
or should they just fallback to newer Token images?
Found the note again I have been looking for
|
We should keep them in DMU anyway as there would be conflicts if we try to move them to DMC. They share some numbers. :/ |
No description provided.