Skip to content

Tokens cleanup (D-E sets) #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Conversation

Eradev
Copy link
Contributor

@Eradev Eradev commented Jul 15, 2025

No description provided.

@Eradev Eradev changed the title Tokens cleanup (D sets) Tokens cleanup (D-E sets) Jul 15, 2025
7 u_2_1_a_phyrexian_myr @Daarken
7 u_2_1_a_myr @Daarken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eradev the problem there is that there is no token script for u_2_1_a_myr anymore because it got updated to the phyrexian one

Copy link
Contributor Author

@Eradev Eradev Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... Maybe we should keep it as tokens don't get errata'd, even if it is not used anymore at the moment? M3C already has the updated token.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then old LivingWeapon cards wouldn't find the old token anymore, for example
because then it would look for germ_phyrexian in old set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some testing but it should fallback to searching for that specific token if it isn't in the set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there is no problem on that front. You can try with Batterskull in NPH. It doesn't have a Germ token and it'll fetch the Phyrexian one without any problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eradev how about "duplicate" the TokenScripts for this, so that both are defined like in the other MRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a Phyrexian Myr token printed in another set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still would prefer to keep it consistent with existing tokens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only duplicated them when existing tokens don't exist yet though (as in no printed version exist)? Otherwise I think it is better to have their correct printing to reflect their type and name correctly without having to double check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tehdiplomat what do you think? should the old Images be duplicated for the new TokenScripts?
or should they just fallback to newer Token images?

@Hanmac
Copy link
Contributor

Hanmac commented Jul 23, 2025

Found the note again I have been looking for

Dominaria United series of 26 tokens

Dominaria United comes with two sets of tokens: a series of 26 bearing either DMU or DMC set codes, and a separate series of 12 tokens with exclusively the DMC set code. We don't know why they did things this way. We've opted to file the entire series of 26 here regardless of set code to avoid archival conflicts.

@Eradev
Copy link
Contributor Author

Eradev commented Jul 23, 2025

We should keep them in DMU anyway as there would be conflicts if we try to move them to DMC. They share some numbers. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants