Skip to content

Clean up mock corpus module #1858

@lukavdplas

Description

@lukavdplas

The frontend has a utility file with mock corpus and corpus field objects for unit tests. This has some issues:

  • All value are defined as constants. If a test requires that you adjust some property, you need to clone these objects, or the test will affect each other.
  • These definitions are quite old and don't match the (more standardised) configurations we use now. For instance, the text content field does not include multifields. The first field is a keyword field with a boolean filter.
  • Most tests use mockCorpus3 and mockField2, but these kind of names are not transparent.

Metadata

Metadata

Assignees

No one assigned

    Labels

    code qualitycode & performance improvements that do not affect user functionalityfrontendchanges to the angular frontend

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions