fix: adjust colors for disabled menu item #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vineethasok
requested changes
Jun 19, 2025
| @@ -105,8 +105,7 @@ export const GenericMenuItem = styled.div` | |||
| font: ${theme.click.genericMenu.item.typography.label.active}; | |||
| } | |||
| &[data-disabled] { | |||
| background:${theme.click.genericMenu.item.color.background.disabled}; | |||
| color:${theme.click.genericMenu.item.color.text.disabled}; | |||
| color:${theme.global.color.text.disabled}; | |||
There was a problem hiding this comment.
This is not right
We need to update token instead of using the text disabled
There was a problem hiding this comment.
do you know how to do it?
I was under the impression that Gareth's the one who does this, but he's not back until July
if we have access, we should update the token 100%
There was a problem hiding this comment.
If you can help with that, it would be great, @vineethasok , otherwise we'll have to wait for Gareth's return.
There was a problem hiding this comment.
I'll create an issue to update the token and revert this line right after it, so that it won't get lost. Will post here a bit later
vineethasok
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we plan to revisit how colors are defined once Gareth is back from his vacation next month
this affects