[client-v2] Adding JSON support with predefined paths #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
There was a problem hiding this comment.
Pull Request Overview
Adds support for handling JSON columns with predefined paths in the ClickHouse client, enabling proper type encoding for RowBinary format instead of Dynamic type encoding when paths are predefined.
- Enhanced JSON column parsing to handle predefined paths with specific data types
- Modified binary reader to use predefined column types when available for JSON data
- Added comprehensive test coverage for various JSON column configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DataTypeTests.java | Adds integration tests for JSON binary format with various predefined path configurations |
| BinaryStreamReader.java | Updates JSON data reading to use predefined column types when available |
| ClickHouseColumn.java | Implements JSON column parsing logic to extract predefined paths and their types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Map<String, Object> row = reader.next(); | ||
| Object value = row.get("value"); | ||
| System.out.println(value); | ||
| } |
There was a problem hiding this comment.
System.out.println should not be used in test code. Consider using a logger or assertion to verify the expected behavior instead.
Suggested change
| } | |
| Object value = row.get("value"); | |
| Assert.assertNotNull(value, "Value should not be null"); | |
| Assert.assertEquals(value, jsonValue, "Retrieved value should match inserted JSON"); | |
| } |
Copilot uses AI. Check for mistakes.
| if (name.startsWith(JSON_SKIP_MARKER)) { | ||
| name = null; // skip parameters | ||
| i = ClickHouseUtils.skipContentsUntil(args, i, len, ',') - 1; | ||
| } else if ( name.startsWith(JSON_MAX_PATHS_PARAM) || name.startsWith(JSON_MAX_DYN_TYPES_PARAM)) { |
There was a problem hiding this comment.
Extra space after opening parenthesis in the if condition.
Suggested change
| } else if ( name.startsWith(JSON_MAX_PATHS_PARAM) || name.startsWith(JSON_MAX_DYN_TYPES_PARAM)) { | |
| } else if (name.startsWith(JSON_MAX_PATHS_PARAM) || name.startsWith(JSON_MAX_DYN_TYPES_PARAM)) { |
Copilot uses AI. Check for mistakes.
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
…imports and undeprecated ClickHouseUtils as we use it
|
mshustov
reviewed
Aug 14, 2025
| public static final String JSON_MAX_DYN_TYPES_PARAM = "max_dynamic_types"; | ||
| public static final String JSON_SKIP_MARKER = "SKIP"; | ||
|
|
||
| public static void parseJSONColumn(String args, List<ClickHouseColumn> nestedColumns, List<String> parameters) { |
There was a problem hiding this comment.
Doesn't it deserve a dedicated set of tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2462
Checklist
Delete items not relevant to your PR: