chore: bump instrument-hooks#87
Merged
Merged
Conversation
not-matthias
force-pushed
the
cod-1380-pytest-codspeed-add-perf-v2-support
branch
from
October 3, 2025 12:06
78032ba to
6d29be0
Compare
CodSpeed Performance ReportMerging #87 will degrade performances by 24.91%Comparing Summary
Benchmarks breakdown
|
not-matthias
force-pushed
the
cod-1380-pytest-codspeed-add-perf-v2-support
branch
4 times, most recently
from
October 3, 2025 12:53
b11f157 to
934ed90
Compare
art049
requested changes
Oct 6, 2025
art049
left a comment
Member
There was a problem hiding this comment.
Just the issue on the duplication of the marker type value, otherwise lgtm
not-matthias
force-pushed
the
cod-1380-pytest-codspeed-add-perf-v2-support
branch
2 times, most recently
from
October 6, 2025 09:53
6230c08 to
68fde1a
Compare
not-matthias
force-pushed
the
cod-1380-pytest-codspeed-add-perf-v2-support
branch
3 times, most recently
from
October 6, 2025 13:48
d928e97 to
cac2943
Compare
Member
|
Seems like there is a build issue @not-matthias |
not-matthias
force-pushed
the
cod-1380-pytest-codspeed-add-perf-v2-support
branch
from
October 6, 2025 14:33
cac2943 to
f6a8a56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding benchmark markers around the inner loop wouldn't help much, and likely just adds more work for little gain. However, I still bumped instrument-hooks since we added a few other features (version cmd, nonblocking IO, …)