-
Notifications
You must be signed in to change notification settings - Fork 183
[9.0] more WMS refactoring #8278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7291fc5
to
03bf6f3
Compare
https://github.com/DIRACGrid/DIRAC/actions/runs/16800399792/job/47580269126?pr=8280 Raised after DIRACGrid/diracx@46d54fe#diff-b98996af9344a5261c4c226a471b99b2487ac28369b2607a3f13b048934f33cf: class JobParameters(BaseModel, extra="forbid"): For the test itself, change the parameters: res = jobStateUpdateClient.setJobParameters(jobID, [("par1", "par1Value"), ("par2", "par2Value")])
# par1 is not found, set a real parameter |
03bf6f3
to
de6c873
Compare
Thank you @Robin-Van-de-Merghel , I was actually looking into this. I do not think this is fully correct, in the sense that job parameters should probably not have a |
de6c873
to
49b4ef0
Compare
I had to remove the |
b37476e
to
d483115
Compare
d483115
to
dc1f63e
Compare
@@ -1,11 +1,10 @@ | |||
from DIRAC import S_ERROR, S_OK, gLogger | |||
from DIRAC.StorageManagementSystem.DB.StorageManagementDB import StorageManagementDB | |||
from DIRAC.WorkloadManagementSystem.Client import JobStatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of src/DIRAC/WorkloadManagementSystem/Client/JobStatus.py
should be moved to Utilities
and reexported into the old location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I (re)moved one utilities from there. I do not see the need to move other content.
a984c76
to
d235a78
Compare
closes #8272