-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Adding JWT support alongside X509 auth #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
feat: Adding JWT support alongside X509 auth #248
Conversation
4b6a0ce
to
15e74e7
Compare
f8b83fd
to
f555e36
Compare
f555e36
to
6c4efbc
Compare
I am still testing the code. Need changes. |
(You need to fix the conflicts with |
627581b
to
f9df3d6
Compare
Improved it so we can just change a parameter in I would like a discussion about storing the JWT:
For now I've chosen the first choice, tell me if you think it is right. |
[Issue with python 2] |
edf8654
to
a5e4df8
Compare
4707c2e
to
404ca41
Compare
Is there other changes to do? |
4ef24e9
to
2840a52
Compare
Better with a command than a function that retrieves the JWT. Uses |
Needs an update to match DiracX's PR. |
b002830
to
bbce239
Compare
TODO: |
Needs a small update to be up to date with the DiracX PR |
0a74076
to
1267c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: BaseRequest etc. isn't used yet for logs because it will be deprecated in the next PR.
371ed6e
to
4b141ab
Compare
173a727
to
ff988d4
Compare
Added
BaseConnectedRequest
to support multiple auth mecanism. Derived from it are two classes:TokenBasedRequest
X509BasedRequest
You can use either of these.
Later, we can transition to a
TokenBasedRequest
. For that, we'll need to replace theX509_USER_PROXY
env variable with aJWT_USER
or something similar.