Lock cache #472
Draft
Lock cache #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
force-pushed
the
lock_cache
branch
2 times, most recently
from
0d3c0a4 to
e50babe
Compare
chrisburr
reviewed
Apr 11, 2025
Comment on lines
+55
to
+71
| enable_otel = False | ||
| try: | ||
| import socket | ||
|
|
||
| name = socket.gethostname() | ||
|
|
||
| for c in name[::-1]: | ||
| try: | ||
| enable_otel = bool(int(c) % 2) | ||
| break | ||
| except ValueError: | ||
| pass | ||
| except Exception as exe: | ||
| logger.exception(exe) | ||
|
|
||
| logger.info(f"Randomly enabling OTEL {enable_otel=}") | ||
| return enable_otel |
There was a problem hiding this comment.
Suggested change
| enable_otel = False | |
| try: | |
| import socket | |
| name = socket.gethostname() | |
| for c in name[::-1]: | |
| try: | |
| enable_otel = bool(int(c) % 2) | |
| break | |
| except ValueError: | |
| pass | |
| except Exception as exe: | |
| logger.exception(exe) | |
| logger.info(f"Randomly enabling OTEL {enable_otel=}") | |
| return enable_otel | |
| enable_otel = bool(int(next(filter(str.isdigit, socket.gethostname() + "0"))) % 2) | |
| logger.info(f"Randomly enabling OTEL {enable_otel=}") | |
| return enable_otel |
There was a problem hiding this comment.
a hell lot less readable 😆
There was a problem hiding this comment.
and it doesn't go backward
|
I think this one can be closed right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.