-
Notifications
You must be signed in to change notification settings - Fork 25
feat (JobDB): pydantic datetime validation #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryuwd
wants to merge
1
commit into
DIRACGrid:main
Choose a base branch
from
ryuwd:roneil-fix-joblogging-offset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
reviewed
Apr 14, 2025
chrisburr
reviewed
Apr 14, 2025
I believe most of this is superseded by #479 but it would be worth keeping the pydantic validators, maybe even expanding the pydantic validation to ensure this doesn't get messed up easily again |
@ryuwd is this PR still needed? |
This can probably be kept but it needs to be adapted after various fixes were made. I will get around to it soon |
c02fb80
to
92d7943
Compare
92d7943
to
74e9829
Compare
5451048
to
7c449e4
Compare
simplify validator [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
7c449e4
to
acc2e3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate provided datetimes to check they are aware and convert them to UTC if needed.