Skip to content

Add job monitoring utilities to the routers #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Robin-Van-de-Merghel
Copy link
Contributor

To update the job monitoring, we need a getInputData and a get_job_parameters router.

@Robin-Van-de-Merghel
Copy link
Contributor Author

With DIRACGrid/DIRAC#8260

search,
sorts,
*,
per_page: int = 10000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a very large number, why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will decrease it*, it was a debug value

@@ -21,7 +21,7 @@ class DummyDB(BaseSQLDB):
# This needs to be here for the BaseSQLDB to create the engine
metadata = DummyDBBase.metadata

async def summary(self, group_by, search) -> list[dict[str, str | int]]:
async def dummy_summary(self, group_by, search) -> list[dict[str, str | int]]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote the search function for BaseDB. The new search function has to be generic, and takes all regular parameters plus a Model which is for example PilotAgents or PilotSecrets.

Calling directly db.summary will require this Model parameter, whereas dummy_summary will add this Model parameter.

Maybe I can rename the generic search function : _search (to make it private)

@Robin-Van-de-Merghel
Copy link
Contributor Author

Need more tests

@Robin-Van-de-Merghel Robin-Van-de-Merghel force-pushed the robin-update-job-monitoring branch from c427dd5 to 83ec8af Compare July 29, 2025 09:34
@Robin-Van-de-Merghel Robin-Van-de-Merghel force-pushed the robin-update-job-monitoring branch from 83ec8af to e7fbedb Compare August 7, 2025 12:47
@Robin-Van-de-Merghel Robin-Van-de-Merghel marked this pull request as ready for review August 7, 2025 12:48
@Robin-Van-de-Merghel
Copy link
Contributor Author

See comments above, we need to review it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants