-
Notifications
You must be signed in to change notification settings - Fork 25
Add job monitoring utilities to the routers #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add job monitoring utilities to the routers #593
Conversation
With DIRACGrid/DIRAC#8260 |
search, | ||
sorts, | ||
*, | ||
per_page: int = 10000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a very large number, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will decrease it*, it was a debug value
@@ -21,7 +21,7 @@ class DummyDB(BaseSQLDB): | |||
# This needs to be here for the BaseSQLDB to create the engine | |||
metadata = DummyDBBase.metadata | |||
|
|||
async def summary(self, group_by, search) -> list[dict[str, str | int]]: | |||
async def dummy_summary(self, group_by, search) -> list[dict[str, str | int]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote the search
function for BaseDB
. The new search
function has to be generic, and takes all regular parameters plus a Model
which is for example PilotAgents
or PilotSecrets
.
Calling directly db.summary
will require this Model
parameter, whereas dummy_summary
will add this Model
parameter.
Maybe I can rename the generic search
function : _search
(to make it private)
Need more tests |
c427dd5
to
83ec8af
Compare
83ec8af
to
e7fbedb
Compare
See comments above, we need to review it... |
To update the job monitoring, we need a
getInputData
and aget_job_parameters
router.