Support vertx 5 by amarziali · Pull Request #8220 · DataDog/dd-trace-java

amarziali · 2025-01-16T09:04:34Z

What Does This Do

Support vertx 5.0 and extend testing. Testing was also not working with JVM >= 17. In particular having maxJavaVersionForTests = 15 was also limiting the java version of latestDep even if it was forced to > 17.
This has been fixed on the java_no-deps gradle build file.

Some latestDepTest for vertx 5 have some asm tests disabled (with FIXME comments). To be tracked

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-01-16T09:04:46Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

vandonr

LGTM, I merely skimmed over the tests assuming they were mostly adapted from the existing ones. Might need an approval from AppSec as well.

pr-commenter · 2025-01-16T09:46:21Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/vertx5
git_commit_date	1737020324	1737021291
git_commit_sha	`148aef9`	`1a5dccd`
release_version	1.46.0-SNAPSHOT~148aef92ab	1.46.0-SNAPSHOT~1a5dccd365

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737023737	1737023737
ci_job_id	768612287	768612287
ci_pipeline_id	53160469	53160469
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064430
Total [baseline] (10.467 s) : 0, 10467337
Agent [candidate] (1.058 s) : 0, 1057779
Total [candidate] (10.44 s) : 0, 10440349
section appsec
Agent [baseline] (1.191 s) : 0, 1191267
Total [baseline] (10.733 s) : 0, 10733459
Agent [candidate] (1.19 s) : 0, 1190198
Total [candidate] (10.711 s) : 0, 10710618
section iast
Agent [baseline] (1.184 s) : 0, 1183731
Total [baseline] (10.976 s) : 0, 10976365
Agent [candidate] (1.206 s) : 0, 1206355
Total [candidate] (10.999 s) : 0, 10999474
section profiling
Agent [baseline] (1.252 s) : 0, 1251594
Total [baseline] (10.813 s) : 0, 10813202
Agent [candidate] (1.257 s) : 0, 1257147
Total [candidate] (10.864 s) : 0, 10863889

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.191 s	126.837 ms (11.9%)
Agent	iast	1.184 s	119.301 ms (11.2%)
Agent	profiling	1.252 s	187.163 ms (17.6%)
Total	tracing	10.467 s	-
Total	appsec	10.733 s	266.122 ms (2.5%)
Total	iast	10.976 s	509.028 ms (4.9%)
Total	profiling	10.813 s	345.865 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.058 s	-
Agent	appsec	1.19 s	132.419 ms (12.5%)
Agent	iast	1.206 s	148.576 ms (14.0%)
Agent	profiling	1.257 s	199.368 ms (18.8%)
Total	tracing	10.44 s	-
Total	appsec	10.711 s	270.269 ms (2.6%)
Total	iast	10.999 s	559.126 ms (5.4%)
Total	profiling	10.864 s	423.54 ms (4.1%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.203 ms) : 0, 720203
BytebuddyAgent [candidate] (715.268 ms) : 0, 715268
GlobalTracer [baseline] (257.681 ms) : 0, 257681
GlobalTracer [candidate] (256.071 ms) : 0, 256071
AppSec [baseline] (56.283 ms) : 0, 56283
AppSec [candidate] (56.536 ms) : 0, 56536
Remote Config [baseline] (728.336 µs) : 0, 728
Remote Config [candidate] (704.966 µs) : 0, 705
Telemetry [baseline] (14.446 ms) : 0, 14446
Telemetry [candidate] (14.121 ms) : 0, 14121
section appsec
BytebuddyAgent [baseline] (732.99 ms) : 0, 732990
BytebuddyAgent [candidate] (732.242 ms) : 0, 732242
GlobalTracer [baseline] (253.749 ms) : 0, 253749
GlobalTracer [candidate] (253.666 ms) : 0, 253666
AppSec [baseline] (171.0 ms) : 0, 171000
AppSec [candidate] (170.709 ms) : 0, 170709
IAST [baseline] (19.327 ms) : 0, 19327
IAST [candidate] (19.378 ms) : 0, 19378
Remote Config [baseline] (655.117 µs) : 0, 655
Remote Config [candidate] (668.218 µs) : 0, 668
Telemetry [baseline] (8.225 ms) : 0, 8225
Telemetry [candidate] (8.186 ms) : 0, 8186
section iast
BytebuddyAgent [baseline] (832.96 ms) : 0, 832960
BytebuddyAgent [candidate] (850.869 ms) : 0, 850869
GlobalTracer [baseline] (246.837 ms) : 0, 246837
GlobalTracer [candidate] (250.022 ms) : 0, 250022
AppSec [baseline] (57.918 ms) : 0, 57918
AppSec [candidate] (58.382 ms) : 0, 58382
IAST [baseline] (21.51 ms) : 0, 21510
IAST [candidate] (22.072 ms) : 0, 22072
Remote Config [baseline] (660.729 µs) : 0, 661
Remote Config [candidate] (687.034 µs) : 0, 687
Telemetry [baseline] (8.791 ms) : 0, 8791
Telemetry [candidate] (8.984 ms) : 0, 8984
section profiling
BytebuddyAgent [baseline] (702.006 ms) : 0, 702006
BytebuddyAgent [candidate] (705.836 ms) : 0, 705836
GlobalTracer [baseline] (348.413 ms) : 0, 348413
GlobalTracer [candidate] (349.688 ms) : 0, 349688
AppSec [baseline] (54.605 ms) : 0, 54605
AppSec [candidate] (54.421 ms) : 0, 54421
Remote Config [baseline] (655.283 µs) : 0, 655
Remote Config [candidate] (659.145 µs) : 0, 659
Telemetry [baseline] (8.736 ms) : 0, 8736
Telemetry [candidate] (8.782 ms) : 0, 8782
ProfilingAgent [baseline] (95.305 ms) : 0, 95305
ProfilingAgent [candidate] (95.759 ms) : 0, 95759
Profiling [baseline] (95.33 ms) : 0, 95330
Profiling [candidate] (95.783 ms) : 0, 95783

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059949
Total [baseline] (8.708 s) : 0, 8708049
Agent [candidate] (1.06 s) : 0, 1059582
Total [candidate] (8.637 s) : 0, 8636637
section iast
Agent [baseline] (1.181 s) : 0, 1180663
Total [baseline] (9.195 s) : 0, 9195030
Agent [candidate] (1.185 s) : 0, 1185256
Total [candidate] (9.223 s) : 0, 9222958
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1183836
Total [baseline] (9.154 s) : 0, 9153782
Agent [candidate] (1.184 s) : 0, 1183841
Total [candidate] (9.233 s) : 0, 9232864
section iast_TELEMETRY_OFF
Agent [baseline] (1.186 s) : 0, 1185689
Total [baseline] (9.26 s) : 0, 9259743
Agent [candidate] (1.189 s) : 0, 1188524
Total [candidate] (9.231 s) : 0, 9231484

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.181 s	120.714 ms (11.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.184 s	123.887 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.186 s	125.74 ms (11.9%)
Total	tracing	8.708 s	-
Total	iast	9.195 s	486.981 ms (5.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.154 s	445.733 ms (5.1%)
Total	iast_TELEMETRY_OFF	9.26 s	551.693 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.185 s	125.673 ms (11.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.184 s	124.258 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.189 s	128.941 ms (12.2%)
Total	tracing	8.637 s	-
Total	iast	9.223 s	586.321 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.233 s	596.227 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.231 s	594.846 ms (6.9%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.275 ms) : 0, 716275
BytebuddyAgent [candidate] (716.338 ms) : 0, 716338
GlobalTracer [baseline] (257.501 ms) : 0, 257501
GlobalTracer [candidate] (256.761 ms) : 0, 256761
AppSec [baseline] (55.764 ms) : 0, 55764
AppSec [candidate] (55.887 ms) : 0, 55887
Remote Config [baseline] (735.957 µs) : 0, 736
Remote Config [candidate] (711.395 µs) : 0, 711
Telemetry [baseline] (14.601 ms) : 0, 14601
Telemetry [candidate] (14.908 ms) : 0, 14908
section iast
BytebuddyAgent [baseline] (830.89 ms) : 0, 830890
BytebuddyAgent [candidate] (833.401 ms) : 0, 833401
GlobalTracer [baseline] (246.294 ms) : 0, 246294
GlobalTracer [candidate] (247.934 ms) : 0, 247934
AppSec [baseline] (57.608 ms) : 0, 57608
AppSec [candidate] (57.991 ms) : 0, 57991
IAST [baseline] (21.398 ms) : 0, 21398
IAST [candidate] (21.407 ms) : 0, 21407
Remote Config [baseline] (658.682 µs) : 0, 659
Remote Config [candidate] (666.867 µs) : 0, 667
Telemetry [baseline] (8.823 ms) : 0, 8823
Telemetry [candidate] (8.727 ms) : 0, 8727
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.386 ms) : 0, 832386
BytebuddyAgent [candidate] (833.067 ms) : 0, 833067
GlobalTracer [baseline] (247.47 ms) : 0, 247470
GlobalTracer [candidate] (247.277 ms) : 0, 247277
AppSec [baseline] (57.965 ms) : 0, 57965
AppSec [candidate] (57.915 ms) : 0, 57915
IAST [baseline] (21.428 ms) : 0, 21428
IAST [candidate] (21.254 ms) : 0, 21254
Remote Config [baseline] (671.461 µs) : 0, 671
Remote Config [candidate] (655.61 µs) : 0, 656
Telemetry [baseline] (8.882 ms) : 0, 8882
Telemetry [candidate] (8.66 ms) : 0, 8660
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.761 ms) : 0, 833761
BytebuddyAgent [candidate] (835.949 ms) : 0, 835949
GlobalTracer [baseline] (248.061 ms) : 0, 248061
GlobalTracer [candidate] (248.75 ms) : 0, 248750
AppSec [baseline] (58.252 ms) : 0, 58252
AppSec [candidate] (58.023 ms) : 0, 58023
IAST [baseline] (21.106 ms) : 0, 21106
IAST [candidate] (21.273 ms) : 0, 21273
Remote Config [baseline] (671.558 µs) : 0, 672
Remote Config [candidate] (671.963 µs) : 0, 672
Telemetry [baseline] (8.699 ms) : 0, 8699
Telemetry [candidate] (8.733 ms) : 0, 8733

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-16T10:06:53	2025-01-16T10:13:56
git_branch	master	andrea.marziali/vertx5
git_commit_date	1737020324	1737021291
git_commit_sha	`148aef9`	`1a5dccd`
release_version	1.46.0-SNAPSHOT~148aef92ab	1.46.0-SNAPSHOT~1a5dccd365
start_time	2025-01-16T10:06:39	2025-01-16T10:13:42

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737022793	1737022793
ci_job_id	768612289	768612289
ci_pipeline_id	53160469	53160469
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1330, 1371
.   : milestone, 1351,
appsec (1.753 ms) : 1730, 1776
.   : milestone, 1753,
appsec_no_iast (1.74 ms) : 1717, 1763
.   : milestone, 1740,
iast (1.484 ms) : 1460, 1509
.   : milestone, 1484,
profiling (1.533 ms) : 1508, 1557
.   : milestone, 1533,
tracing (1.489 ms) : 1465, 1514
.   : milestone, 1489,
section candidate
no_agent (1.338 ms) : 1318, 1357
.   : milestone, 1338,
appsec (1.754 ms) : 1730, 1778
.   : milestone, 1754,
appsec_no_iast (1.766 ms) : 1741, 1790
.   : milestone, 1766,
iast (1.509 ms) : 1484, 1534
.   : milestone, 1509,
profiling (1.517 ms) : 1491, 1542
.   : milestone, 1517,
tracing (1.472 ms) : 1446, 1497
.   : milestone, 1472,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.33 ms, 1.371 ms]	-
appsec	1.753 ms [1.73 ms, 1.776 ms]	402.203 µs (29.8%)
appsec_no_iast	1.74 ms [1.717 ms, 1.763 ms]	389.248 µs (28.8%)
iast	1.484 ms [1.46 ms, 1.509 ms]	133.381 µs (9.9%)
profiling	1.533 ms [1.508 ms, 1.557 ms]	182.014 µs (13.5%)
tracing	1.489 ms [1.465 ms, 1.514 ms]	138.632 µs (10.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.338 ms [1.318 ms, 1.357 ms]	-
appsec	1.754 ms [1.73 ms, 1.778 ms]	416.183 µs (31.1%)
appsec_no_iast	1.766 ms [1.741 ms, 1.79 ms]	427.933 µs (32.0%)
iast	1.509 ms [1.484 ms, 1.534 ms]	171.649 µs (12.8%)
profiling	1.517 ms [1.491 ms, 1.542 ms]	178.918 µs (13.4%)
tracing	1.472 ms [1.446 ms, 1.497 ms]	134.173 µs (10.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.258 µs) : 355, 394
.   : milestone, 374,
iast (503.778 µs) : 482, 526
.   : milestone, 504,
iast_FULL (736.857 µs) : 715, 759
.   : milestone, 737,
iast_GLOBAL (545.882 µs) : 524, 568
.   : milestone, 546,
iast_HARDCODED_SECRET_DISABLED (504.193 µs) : 482, 526
.   : milestone, 504,
iast_INACTIVE (456.571 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (495.457 µs) : 473, 518
.   : milestone, 495,
tracing (448.249 µs) : 427, 469
.   : milestone, 448,
section candidate
no_agent (381.385 µs) : 361, 402
.   : milestone, 381,
iast (512.239 µs) : 490, 534
.   : milestone, 512,
iast_FULL (738.949 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (560.401 µs) : 539, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (501.287 µs) : 480, 523
.   : milestone, 501,
iast_INACTIVE (450.507 µs) : 429, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (491.528 µs) : 469, 514
.   : milestone, 492,
tracing (446.752 µs) : 426, 467
.   : milestone, 447,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.258 µs [354.803 µs, 393.713 µs]	-
iast	503.778 µs [482.017 µs, 525.539 µs]	129.52 µs (34.6%)
iast_FULL	736.857 µs [714.982 µs, 758.733 µs]	362.6 µs (96.9%)
iast_GLOBAL	545.882 µs [524.183 µs, 567.581 µs]	171.625 µs (45.9%)
iast_HARDCODED_SECRET_DISABLED	504.193 µs [482.171 µs, 526.215 µs]	129.935 µs (34.7%)
iast_INACTIVE	456.571 µs [435.548 µs, 477.594 µs]	82.313 µs (22.0%)
iast_TELEMETRY_OFF	495.457 µs [473.236 µs, 517.678 µs]	121.199 µs (32.4%)
tracing	448.249 µs [427.465 µs, 469.033 µs]	73.991 µs (19.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.385 µs [360.794 µs, 401.976 µs]	-
iast	512.239 µs [490.246 µs, 534.233 µs]	130.854 µs (34.3%)
iast_FULL	738.949 µs [717.113 µs, 760.784 µs]	357.563 µs (93.8%)
iast_GLOBAL	560.401 µs [538.659 µs, 582.142 µs]	179.015 µs (46.9%)
iast_HARDCODED_SECRET_DISABLED	501.287 µs [479.746 µs, 522.828 µs]	119.902 µs (31.4%)
iast_INACTIVE	450.507 µs [429.328 µs, 471.686 µs]	69.122 µs (18.1%)
iast_TELEMETRY_OFF	491.528 µs [469.344 µs, 513.711 µs]	110.143 µs (28.9%)
tracing	446.752 µs [426.157 µs, 467.346 µs]	65.366 µs (17.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/vertx5
git_commit_date	1737020324	1737021291
git_commit_sha	`148aef9`	`1a5dccd`
release_version	1.46.0-SNAPSHOT~148aef92ab	1.46.0-SNAPSHOT~1a5dccd365

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737023290	1737023290
ci_job_id	768612291	768612291
ci_pipeline_id	53160469	53160469
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.372 ms) : 2329, 2416
.   : milestone, 2372,
iast (2.108 ms) : 2054, 2163
.   : milestone, 2108,
iast_GLOBAL (2.161 ms) : 2106, 2215
.   : milestone, 2161,
profiling (2.445 ms) : 2208, 2682
.   : milestone, 2445,
tracing (1.964 ms) : 1922, 2006
.   : milestone, 1964,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.354 ms) : 2312, 2397
.   : milestone, 2354,
iast (2.109 ms) : 2055, 2163
.   : milestone, 2109,
iast_GLOBAL (2.151 ms) : 2096, 2205
.   : milestone, 2151,
profiling (1.995 ms) : 1951, 2039
.   : milestone, 1995,
tracing (1.953 ms) : 1911, 1995
.   : milestone, 1953,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.465 ms, 1.488 ms]	-
appsec	2.372 ms [2.329 ms, 2.416 ms]	895.684 µs (60.7%)
iast	2.108 ms [2.054 ms, 2.163 ms]	631.792 µs (42.8%)
iast_GLOBAL	2.161 ms [2.106 ms, 2.215 ms]	684.131 µs (46.3%)
profiling	2.445 ms [2.208 ms, 2.682 ms]	968.415 µs (65.6%)
tracing	1.964 ms [1.922 ms, 2.006 ms]	487.277 µs (33.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.354 ms [2.312 ms, 2.397 ms]	878.188 µs (59.5%)
iast	2.109 ms [2.055 ms, 2.163 ms]	633.193 µs (42.9%)
iast_GLOBAL	2.151 ms [2.096 ms, 2.205 ms]	674.84 µs (45.7%)
profiling	1.995 ms [1.951 ms, 2.039 ms]	518.775 µs (35.1%)
tracing	1.953 ms [1.911 ms, 1.995 ms]	476.925 µs (32.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.718 s) : 14718000, 14718000
.   : milestone, 14718000,
appsec (15.195 s) : 15195000, 15195000
.   : milestone, 15195000,
iast (18.797 s) : 18797000, 18797000
.   : milestone, 18797000,
iast_GLOBAL (17.861 s) : 17861000, 17861000
.   : milestone, 17861000,
profiling (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
tracing (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
section candidate
no_agent (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
appsec (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
iast (19.101 s) : 19101000, 19101000
.   : milestone, 19101000,
iast_GLOBAL (17.76 s) : 17760000, 17760000
.   : milestone, 17760000,
profiling (15.762 s) : 15762000, 15762000
.   : milestone, 15762000,
tracing (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.718 s [14.718 s, 14.718 s]	-
appsec	15.195 s [15.195 s, 15.195 s]	477.0 ms (3.2%)
iast	18.797 s [18.797 s, 18.797 s]	4.079 s (27.7%)
iast_GLOBAL	17.861 s [17.861 s, 17.861 s]	3.143 s (21.4%)
profiling	14.965 s [14.965 s, 14.965 s]	247.0 ms (1.7%)
tracing	15.011 s [15.011 s, 15.011 s]	293.0 ms (2.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.941 s [14.941 s, 14.941 s]	-
appsec	15.026 s [15.026 s, 15.026 s]	85.0 ms (0.6%)
iast	19.101 s [19.101 s, 19.101 s]	4.16 s (27.8%)
iast_GLOBAL	17.76 s [17.76 s, 17.76 s]	2.819 s (18.9%)
profiling	15.762 s [15.762 s, 15.762 s]	821.0 ms (5.5%)
tracing	15.054 s [15.054 s, 15.054 s]	113.0 ms (0.8%)

manuel-alvarez-alvarez

I've created a JIRA ticket APPSEC-56368 to review support for vert.x 5 in ASM, thanks for spotting the missing pieces 😄

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

amarziali requested review from a team as code owners January 16, 2025 09:04

amarziali requested review from dougqh, jandro996 and sezen-datadog January 16, 2025 09:04

amarziali requested a review from smola January 16, 2025 09:05

datadog-datadog-prod-us1 Bot reviewed Jan 16, 2025

View reviewed changes

amarziali requested a review from vandonr January 16, 2025 09:05

amarziali added type: feature Enhancements and improvements inst: vertx Eclipse Vert.x instrumentation labels Jan 16, 2025

smola requested a review from manuel-alvarez-alvarez January 16, 2025 09:13

vandonr reviewed Jan 16, 2025

View reviewed changes

Comment thread gradle/java_no_deps.gradle Outdated

vandonr approved these changes Jan 16, 2025

View reviewed changes

Support vertx 5

1a5dccd

amarziali force-pushed the andrea.marziali/vertx5 branch from 1cd0dce to 1a5dccd Compare January 16, 2025 09:55

manuel-alvarez-alvarez approved these changes Jan 16, 2025

View reviewed changes

amarziali enabled auto-merge (squash) January 16, 2025 10:44

amarziali added comp: api Tracer public API and removed comp: api Tracer public API labels Jan 16, 2025

amarziali merged commit 296ed7b into master Jan 16, 2025

amarziali deleted the andrea.marziali/vertx5 branch January 16, 2025 10:58

github-actions Bot added this to the 1.46.0 milestone Jan 16, 2025

amarziali mentioned this pull request Jan 17, 2025

Fix vertx worker propagation and error handling #8237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support vertx 5 - #8220

Support vertx 5#8220
amarziali merged 1 commit into
masterfrom
andrea.marziali/vertx5

amarziali commented Jan 16, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vandonr left a comment

Uh oh!

pr-commenter Bot commented Jan 16, 2025 •

edited

Loading

Uh oh!

manuel-alvarez-alvarez left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amarziali commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions Bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vandonr left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter Bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amarziali commented Jan 16, 2025 •

edited

Loading

github-actions Bot commented Jan 16, 2025 •

edited

Loading

pr-commenter Bot commented Jan 16, 2025 •

edited

Loading