Check class_id validity in DetectionDataset#1536
Merged
Louis-Dupont merged 11 commits intoOct 17, 2023
Merged
Conversation
Louis-Dupont
marked this pull request as ready for review
October 17, 2023 07:36
Louis-Dupont
requested review from
BloodAxe,
ofrimasad and
shaydeci
as code owners
October 17, 2023 07:36
BloodAxe
reviewed
Oct 17, 2023
BloodAxe
reviewed
Oct 17, 2023
…#1533) * Ensure that `checkpoint_num_classes` is propagated from YAML to models.get() * Red checkpoint_num_classes via get_params
Louis-Dupont
deleted the
feature/SG-868-add_exception_when_classid_not_valid
branch
October 17, 2023 13:41
Louis-Dupont
added a commit
that referenced
this pull request
Oct 17, 2023
* first draft * fix * fix * fix detectiondataset * Ensure that `checkpoint_num_classes` is propagated from YAML to model (#1533) * Ensure that `checkpoint_num_classes` is propagated from YAML to models.get() * Red checkpoint_num_classes via get_params * Fixed a bug in export() that prevented to export model for BS>1 (#1530) * Remove unnecessary files (#1540) * remove check on base class --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Louis-Dupont
added a commit
that referenced
this pull request
Oct 18, 2023
* first draft * fix * fix * fix detectiondataset * Ensure that `checkpoint_num_classes` is propagated from YAML to model (#1533) * Ensure that `checkpoint_num_classes` is propagated from YAML to models.get() * Red checkpoint_num_classes via get_params * Fixed a bug in export() that prevented to export model for BS>1 (#1530) * Remove unnecessary files (#1540) * remove check on base class --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 checks were added to make sure class_id is in the range of (0, num_classes-1)
DetectionDataset: added a check when loading annotations and raise an exception if this happensYoloDarknetDataset: add a check when parsing.