Skip to content

Updated "What are Recipes and How To Use Them" notebook#1586

Merged
BloodAxe merged 4 commits into
masterfrom
feature/SG-1189-update-notebooks
Oct 30, 2023
Merged

Updated "What are Recipes and How To Use Them" notebook#1586
BloodAxe merged 4 commits into
masterfrom
feature/SG-1189-update-notebooks

Conversation

@BloodAxe

Copy link
Copy Markdown
Contributor

No description provided.

@shaydeci shaydeci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two things:

  1. Shouldn't we update Makefile to include the notebook docs (run_and_convert_notebooks_to_docs)?
  2. Please use pip install XXX &> /dev/null or drop output so we don't trash notebook output.

@BloodAxe

Copy link
Copy Markdown
Contributor Author

Looks good. Just two things:

  1. Shouldn't we update Makefile to include the notebook docs (run_and_convert_notebooks_to_docs)?
  2. Please use pip install XXX &> /dev/null or drop output so we don't trash notebook output.

Fixed in 60c244b
Thanks for suggestions

@shaydeci shaydeci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe
BloodAxe merged commit b71abd6 into master Oct 30, 2023
@BloodAxe
BloodAxe deleted the feature/SG-1189-update-notebooks branch October 30, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants