Fixed bug in ModelWeightAveraging class that led to corrupted model when metric to watch was NaN/Inf#1598
Merged
Conversation
BloodAxe
requested review from
Louis-Dupont,
ofrimasad and
shaydeci
as code owners
November 1, 2023 07:41
Louis-Dupont
approved these changes
Nov 1, 2023
Louis-Dupont
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just make sure the greater_is_better without default is fine for classification (as raised by ofri)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A class was not checking whether observed metric is a finite number and included a state dict of the model that had inf/nan metric value into averaging.
The fix was three-liner: