Enforced check of that all notebooks has matching SG version installed#1607
Merged
Conversation
BloodAxe
requested review from
Louis-Dupont,
ofrimasad and
shaydeci
as code owners
November 3, 2023 11:06
This was referenced Nov 3, 2023
Merged
and simplified way of adding new notebooks
Contributor
Author
|
You are correct. When we want to release, we have to update version in SG notebook and (ideally) run them against this new version. So the workflow is the following
Commit changes to reflect updated docs in documentation |
# Conflicts: # Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue with regex in checking version of SG package (Now both
pip install super-gradientsandpip install super_gradietnscommands are parsed correctly)It also simplify Makefile by splitting NOTEBOOKS variable into NOTEBOOKS_TO_CHECK and NOTEBOOKS_TO_RUN
These variables are no multi-line, which makes it easier to merge PRs where notebooks are added.
And lastly, now
check_notebooks_version_matchis a part of breaking change test to enforce our notebooks are up-to-date.