Skip to content

fix(vmm-cli): compatible with custom kms-url and gateway-url #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

fix(vmm-cli): compatible with custom kms-url and gateway-url #179

merged 2 commits into from
May 23, 2025

Conversation

Leechael
Copy link
Collaborator

@Leechael Leechael commented May 22, 2025 •
edited
Loading

fix vmm-cli when testing customize kms_urls and gateway_urls.

@Leechael Leechael marked this pull request as ready for review May 22, 2025 16:23
@Leechael Leechael requested a review from kvinwang May 22, 2025 16:24
kvinwang
kvinwang approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leechael Leechael merged commit 82f5ab9 into cvm-kms-url May 23, 2025
@Leechael Leechael deleted the fix-vmm-cli branch May 23, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvinwang kvinwang kvinwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leechael @kvinwang