Fix transition typo

[MariaSolOs]

Fixing a typo in these variable names.

This is a breaking change, and so I'm open to deprecating the older variable name as a more flexible change instead. See discussion below for the resolution.

[ErikReider]

Great catch!

This is a breaking change, and so I'm open to deprecating the older variable name as a more flexible change instead.

Yeah, this would be preferred. I'd do it by re-adding those, referring to the new variables (--group-collapse-tranistion: var(--group-collapse-transition)) and add a comment above explaining the issue :)

[MariaSolOs]

@ErikReider sounds good! However I don't think there's a straightforward way to deprecate sass variables. Would you be okay with an approach like this?

[ErikReider]

@ErikReider sounds good! However I don't think there's a straightforward way to deprecate sass variables. Would you be okay with an approach like this?

The variables in use currently are pure css and not sass variables so that would sadly not work...

[MariaSolOs]

The variables in use currently are pure css and not sass variables so that would sadly not work...

Oh... in that case we won't be able to provide a runtime warning about the deprecation of the variables. Besides the comments, is there anything else I should do to let users know of this change?

[ErikReider]

Oh... in that case we won't be able to provide a runtime warning about the deprecation of the variables. Besides the comments, is there anything else I should do to let users know of this change?

Not really. I'll probably leave them there for a while to not break any more themes. The GTK4 port caused enough breakage for a while xD

[ErikReider]

Thanks again! I should really get spell checking working in vim... 😆

[MariaSolOs]

Thanks again! I should really get spell checking working in vim... 😆

No worries! And thanks to you for the awesome project and kind review of this PR!