-
Notifications
You must be signed in to change notification settings - Fork 11
[New] Apply hillshade renderer to raster #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this sample! I'll give a more in-depth review once the build issues have been resolved.
...les/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.SettingsView.swift
Outdated
Show resolved
Hide resolved
...les/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.SettingsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Caleb Rasmussen <[email protected]>
…com/Esri/arcgis-maps-sdk-swift-samples into ryan/ApplyHillshadeRendererToRaster
Co-authored-by: Ting <[email protected]>
…com/Esri/arcgis-maps-sdk-swift-samples into ryan/ApplyHillshadeRendererToRaster
Shared/Samples/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.swift
Outdated
Show resolved
Hide resolved
...les/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.SettingsView.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of my suggestions, take them or leave them:
Shared/Samples/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Apply hillshade renderer to raster/ApplyHillshadeRendererToRasterView.swift
Outdated
Show resolved
Hide resolved
...d/Samples/Apply hillshade renderer to raster/apply-hillshade-renderer-to-raster-settings.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Caleb Rasmussen <[email protected]> Co-authored-by: Ting <[email protected]>
Co-authored-by: Ting <[email protected]>
…com/Esri/arcgis-maps-sdk-swift-samples into ryan/ApplyHillshadeRendererToRaster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making those changes!
Description
This PR implements
ApplyHillshadeRendererToRaster
inVisualization
category.Linked Issue(s)
swift/issues/6849
How To Test
Try different settings
Screenshots