Skip to content

[New] Apply hillshade renderer to raster #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
May 7, 2025

Conversation

rolson
Copy link
Collaborator

@rolson rolson commented May 6, 2025

Description

This PR implements ApplyHillshadeRendererToRaster in Visualization category.

Linked Issue(s)

  • swift/issues/6849

How To Test

Try different settings

Screenshots

image

@rolson rolson requested review from yo1995 and CalebRas May 6, 2025 21:59
@rolson rolson self-assigned this May 6, 2025
@rolson rolson changed the title New Sample: Apply hillshade renderer to raster [NEW] Apply hillshade renderer to raster May 6, 2025
@rolson rolson changed the title [NEW] Apply hillshade renderer to raster [New] Apply hillshade renderer to raster May 6, 2025
Copy link
Collaborator

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this sample! I'll give a more in-depth review once the build issues have been resolved.

@rolson rolson requested review from yo1995 and CalebRas May 7, 2025 15:30
Copy link
Collaborator

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of my suggestions, take them or leave them:

@rolson rolson requested review from CalebRas and yo1995 May 7, 2025 19:12
Copy link
Collaborator

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making those changes!

@rolson rolson merged commit 56a70c0 into v.next May 7, 2025
1 check passed
@rolson rolson deleted the ryan/ApplyHillshadeRendererToRaster branch May 7, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants