-
Notifications
You must be signed in to change notification settings - Fork 11
[New] Browse WFS layers #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of a big overlay blocking the map, I borrowed from the old IWA sample. This makes for a nice user experience, especially on iPhone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
Co-authored-by: Ting <[email protected]>
I didn't use it at first because I was concerned about a cancellation alert being presented as the view is popped from the stack while loading the service, but that doesn't seem to be a problem.
This reverts commit e957129.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some suggestions:
Co-authored-by: Caleb Rasmussen <[email protected]>
Description
This PR implements
Browse WFS layers
in theLayers
category.URL to README: URL
Linked Issue(s)
swift/issues/6860
How To Test
Open the sample, load a WFS service, select a layer, and wait for the features to be populated. Toggle the switch if necessary.
Screenshots