Skip to content

[New] Browse WFS layers #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2025
Merged

Conversation

philium
Copy link
Contributor

@philium philium commented May 19, 2025

Description

This PR implements Browse WFS layers in the Layers category.
URL to README: URL

Linked Issue(s)

  • swift/issues/6860

How To Test

Open the sample, load a WFS service, select a layer, and wait for the features to be populated. Toggle the switch if necessary.

Screenshots

1 2 3
browse-wfs-layers-1 browse-wfs-layers-2 browse-wfs-layers-3

@philium philium requested review from yo1995 and CalebRas May 19, 2025 20:15
@philium philium self-assigned this May 19, 2025
@philium
Copy link
Contributor Author

philium commented May 19, 2025

Instead of a big overlay blocking the map, I borrowed from the old IWA sample. This makes for a nice user experience, especially on iPhone.

Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

philium and others added 2 commits May 19, 2025 16:45
I didn't use it at first because I was concerned about a cancellation alert being presented as the view is popped from the stack while loading the service, but that doesn't seem to be a problem.
@philium philium requested a review from yo1995 May 19, 2025 23:54
@philium philium requested a review from yo1995 May 20, 2025 00:20
yo1995
yo1995 previously approved these changes May 20, 2025
Copy link
Collaborator

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some suggestions:

@philium philium requested review from CalebRas and yo1995 May 20, 2025 19:53
@philium philium merged commit 97faf81 into v.next May 20, 2025
1 check passed
@philium philium deleted the philium/add-browse-wfs-layers-sample branch May 20, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants