Remove dynamic memory allocation inside tight loops in the Plaza refinement code #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
force-pushed
the
garth/plaza-allocation
branch
from
5ada84a to
bedc8af
Compare
Co-authored-by: Chris Richardson <[email protected]>
…to garth/plaza-allocation
Co-authored-by: Chris Richardson <[email protected]>
| bool compute_parent_cell | ||
| = (option == plaza::Option::parent_cell | ||
| or option == plaza::Option::parent_cell_and_facet); | ||
| bool compute_facets = option == plaza::Option::parent_facet |
There was a problem hiding this comment.
I think I really prefer it with the brackets.
There was a problem hiding this comment.
Feel free to add back.
chrisrichardson
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43.
Returns statically allocated data plus the size.