Mixed dimension assembly in C++ and form independence for subdomains #3262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
added
enhancement
jorgensd
changed the title
jorgensd
changed the title
* Add subdomains to form creation independent of mesh * Try some fixes * Try fixing wrapper * Fix subdomain data packing
jorgensd
changed the title
Required for more advanced integration sets that are outside the standard compute_integral_data way.
jpdean
reviewed
Aug 15, 2024
| """ | ||
| sd = form.ufl_form.subdomain_data() |
|
Maybe the description could be updated to remove the comment on shared pointers? |
Addressed and all other comments have been addressed as well. |
chrisrichardson
approved these changes
Aug 28, 2024
schnellerhase
pushed a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Sep 11, 2024
…EniCS#3262) * Modify interface of all C++ demos * Add newline * Fix C++ unit tests * Update create form * Update code to use self made ptr * Dokken/subdomain form independent (FEniCS#3287) * Add subdomains to form creation independent of mesh * Try some fixes * Try fixing wrapper * Fix subdomain data packing * ruff fix * Update binding * Fix docstrings and let user pass in integration entities. Required for more advanced integration sets that are outside the standard compute_integral_data way. * Address Joe's comments * Rename * Update docs * Rename test function --------- Co-authored-by: Chris Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the mixed (dimensional) assembly functions to C++ and adds a demo.
Would resolve #3113.
This PR also simplifies the newly created mesh independent form creation (#3263) such that the user can send in integration entities.
Added additional test that exposes this feature in the context of sub-meshes for a rank-1 tensor.