Make ISBRH render ID static final and make registration explicit #4745
+28
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of via object constructor
Alexdoru
added
the
Refactor
leagris
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object constructors should be only setting up fields.
They should not be assigning static fields.
They should not be registering
thisto something.new Objectsshouldn't be dangling in the code without anything using them because it turns out the constructor is actually running code that is doing doing somthing other than just constructing the object.This PR removes the above and replaces it with explicit registration in the form
Something.register(new SomeISBRH()for ISimpleBlockRenderingHandler.It also makes the render static final to clearly indicate that it should never change.