feat: Add buildable giskard meta-package and release workflow support#2404
Merged
Conversation
Made-with: Cursor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a giskard_pypi_shim module and configures the build system using hatchling in pyproject.toml to facilitate a meta-distribution. Feedback suggests ensuring the LICENSE file is included in the source distribution and removing the ignore-vcs setting to avoid including unintended local files.
Made-with: Cursor
Bump giskard to 3.0.0b1 and giskard-checks to expose an `all` extra. Restructure root optional-dependencies into named provider/checks/scan extras with an aggregated `full` target, and switch the dev group to giskard[full]. Fix invalid TOML in the `full` extra (missing quotes). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reduce the "Resolve package paths" step to a single `dir` output and derive pyproject/dist paths inline at each consumer. Also fix a double-space typo in the all-checks extra. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The giskard-llm version floors (>=1.0.1b3) were unsatisfiable from PyPI: giskard-llm is published at 1.0.0b4, and per PEP 440 1.0.0b4 < 1.0.1b3. This broke `pip install giskard[openai|google|anthropic|all-llms|full]` for end users; the uv workspace masked it via editable installs. - Lower openai/google/anthropic/all-llms floors to >=1.0.0b4 - Point azure extra at giskard-llm[azure] to track its upstream alias instead of the self-referential giskard[openai] - Clean dist/ before uv build in the release workflow Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
henchaves
approved these changes
Jun 23, 2026
# Conflicts: # pyproject.toml # uv.lock
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Newer openai/anthropic SDKs added error classes with constructor signatures that don't accept (message, response, body) -- e.g. openai.OAuthError and anthropic.APIWebhookValidationError. Build the exception kwargs from the constructor signature instead of hard-coding them, so the mapping-completeness tests survive SDK upgrades. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add buildable giskard meta-package and release workflow support in order to allow installing Giskard packages using
pip install giskard