Skip to content

fix(agents): surface unknown workflow tool calls#2414

Merged
kevinmessiaen merged 4 commits into
Giskard-AI:mainfrom
alexanderkreidich:fix/2413-unknown-tool-calls
Jun 26, 2026
Merged

fix(agents): surface unknown workflow tool calls#2414
kevinmessiaen merged 4 commits into
Giskard-AI:mainfrom
alexanderkreidich:fix/2413-unknown-tool-calls

Conversation

@alexanderkreidich

Copy link
Copy Markdown
Contributor

Summary

  • stop ChatWorkflow when an assistant requests a tool name that is not registered on the workflow
  • raise a descriptive error that includes the unknown tool name, tool call id, and registered tool names
  • add regression coverage for both the default raise path and ErrorPolicy.RETURN

Testing

  • uv run pytest libs/giskard-agents/tests/test_workflow_error_handling.py -k unknown_tool_call -q
  • uv run pytest libs/giskard-agents/tests/test_workflow_error_handling.py -q
  • make check
  • make test-unit PACKAGE=giskard-agents

Closes #2413

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error handling in the ChatWorkflow by raising a ValueError when an unknown tool is called, replacing the previous behavior of silently skipping such calls. The error message now provides helpful context, including the name of the missing tool and a list of available tools. Additionally, new test cases were added to ensure that these errors are correctly handled and reported. I have no feedback to provide.

@kevinmessiaen kevinmessiaen changed the title fix(agents): surface unknown workflow tool calls 🤖🤖🤖🤖 fix(agents): surface unknown workflow tool calls Jun 26, 2026
@kevinmessiaen
kevinmessiaen enabled auto-merge (squash) June 26, 2026 04:02
Align UnknownToolCallGenerator with CompletionResponse and giskard.llm.types so PR Giskard-AI#2414 tests compile and pass after the generator refactor.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kevinmessiaen
kevinmessiaen disabled auto-merge June 26, 2026 05:32
@kevinmessiaen
kevinmessiaen merged commit 78a25a7 into Giskard-AI:main Jun 26, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Giskard-agents: Workflow silently ignores unknown tool calls

3 participants