Move data manipulation functions to external header #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
reviewed
May 28, 2025
dzenanz
approved these changes
May 28, 2025
|
You can see errors and warnings here. Search for |
dzenanz
approved these changes
May 29, 2025
ebald19
force-pushed
the
bugfix/fix_isq_header_write
branch
2 times, most recently
from
a216805 to
3864354
Compare
dzenanz
reviewed
May 29, 2025
include/itkDataManipulation.h
Outdated
| @@ -1,119 +0,0 @@ | |||
| /*========================================================================= | |||
There was a problem hiding this comment.
I assume these file deletions should have been in a previous commit? Also it might make sense to squash commits 2 and 3, to avoid appearance of itkDataManipulation.h only to be immediately renamed.
STYLE: Move unrelated data manipulation functions out of main class STYLE: Add and update doxygen comments for functions BUG: remove depreciated sprintf
ebald19
force-pushed
the
bugfix/fix_isq_header_write
branch
from
3864354 to
6da674c
Compare
|
If you mark this as "ready for review" I will squash-merge it. |
dzenanz
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There were multiple functions within the ScancoIO class that did not depend on or use any class-specific values. These functions are all related to manipulating raw data or strings and decoding/conversions to and from typed data. These currently clutter among the related IO functions for the class.
Additionally, these functions affect part of the issues seen in this issue. Specifically, the dates when written to an ISQ header are not correctly converted to the OpenVMS timestamps which have a different epoch. This caused 'garbage' dates to be written with the buggy conversion.
Proposed Changes
EncodeDatefunction to beEncodeCurrentDateNotes:
itkDataManipulation.h/cxxare added files and an associated line is added for these to be compiled with cmake in theCMakeLists.txt-> This file's name and organization method can be modified easily if preferred