Restructure and Refactor Header Handling #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
reviewed
Jun 18, 2025
ebald19
force-pushed
the
enhancement/incorporate_aimio_1
branch
from
afb9f73 to
eff0146
Compare
STYLE: documentation and style fixes
BUG: fix pixel and physical dimension population for writing
- have metadata dictionary populate and save dimension values
BUG: fix microsoft-specific errors and register scancoio for use in test for aim writing
WIP: Have write convert back to Scanco units
Merge changes from incorporate aimio:
WIP: Move header reading/writing to completely depend on subclass ScancoHeaderIO
WIP: Have ISQ write all metadata as read in
WIP: Use AimIO method for reading ISQ
This method defines header structures and reads header bytes directly into them for access
- add test for reader update in conversion test
WIP: Complete reading extended header from data struct
- add documentation and style fixes
WIP: have aim reader use struct header datatype
WIP: switch reading to scancoheaderio class
WIP: add class files for header reader and writers
WIP: add class files and definitions for separating header reading and
writing
Merge changes from main:
BUG: fix creation date output in header write
STYLE: Move unrelated data manipulation functions out of main class
STYLE: Add and update doxygen comments for functions
STYLE: fix spacing for ITK style checks
BUG: fix CI and compiler warnings and errors
BUG: remove depreciated sprintf
ebald19
force-pushed
the
enhancement/incorporate_aimio_1
branch
from
eff0146 to
1308359
Compare
|
You seem to have forgotten to apply clang-format, otherwise LGTM. |
|
Ah, you realized that too and made quick force-push. Let's wait and see what the CI says. |
mkuczyns
reviewed
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the functionality of the proposal in this issue.
Changes
API Differences
Future Changes
Incoming PRs will handle writing to AIM files, testing for AIM v030, and float type compatibility for writing