Skip to content

Dense jacobians #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 10, 2023
Merged

Dense jacobians #111

merged 11 commits into from
Aug 10, 2023

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Aug 10, 2023

Replace linear operators with dense jacobians for the direct linear solver

Type unstable due to AbstractDifferentiation.jl, so i commented it out

Also shortened the benchmark

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.44% 🎉

Comparison is base (22c092b) 95.88% compared to head (40c05fb) 98.32%.

❗ Current head 40c05fb differs from pull request most recent head 3c77db4. Consider uploading reports for the commit 3c77db4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   95.88%   98.32%   +2.44%     
==========================================
  Files           9        9              
  Lines         170      179       +9     
==========================================
+ Hits          163      176      +13     
+ Misses          7        3       -4     
Files Changed Coverage Δ
src/ImplicitDifferentiation.jl 62.50% <ø> (+50.00%) ⬆️
src/linear_solver.jl 100.00% <ø> (ø)
ext/ImplicitDifferentiationChainRulesCoreExt.jl 100.00% <100.00%> (ø)
ext/ImplicitDifferentiationForwardDiffExt.jl 100.00% <100.00%> (ø)
src/operators.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit f5b1efb into main Aug 10, 2023
@gdalle gdalle deleted the dense_jacobians branch August 10, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant