Skip to content

feat: add least-squares linear solver #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 16, 2025
Merged

feat: add least-squares linear solver #185

merged 8 commits into from
Aug 16, 2025

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Aug 6, 2025

  • Define IterativeLeastSquaresSolver for situations where the conditions $c$ have a different type than the solution $y$
  • In these cases, we need both $A$ and $A^\top$ (as linear operators or matrices), which required updating the linear solver interface
  • Add tests and fix the default solver so that $A \neq A^\top$

Codecov is not updating so I'm gonna merge to see what it looks like on main

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/settings.jl 50.00% 7 Missing ⚠️
ext/ImplicitDifferentiationChainRulesCoreExt.jl 76.92% 3 Missing ⚠️
ext/ImplicitDifferentiationForwardDiffExt.jl 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
ext/ImplicitDifferentiationZygoteExt.jl 100.00% <100.00%> (ø)
src/ImplicitDifferentiation.jl 100.00% <ø> (ø)
src/implicit_function.jl 100.00% <ø> (ø)
ext/ImplicitDifferentiationForwardDiffExt.jl 95.45% <85.71%> (-4.55%) ⬇️
ext/ImplicitDifferentiationChainRulesCoreExt.jl 89.28% <76.92%> (-6.37%) ⬇️
src/settings.jl 74.07% <50.00%> (-25.93%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle marked this pull request as ready for review August 16, 2025 19:35
@gdalle gdalle merged commit 5380155 into main Aug 16, 2025
3 checks passed
@gdalle gdalle deleted the gd/leastsquares branch August 16, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant