-
Notifications
You must be signed in to change notification settings - Fork 41
Makie extension v2 #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makie extension v2 #174
Conversation
I'd be happy to bump minimum Julia version to v1.10 if that helps with maintenance |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 94.61% 94.51% -0.11%
==========================================
Files 14 15 +1
Lines 762 766 +4
==========================================
+ Hits 721 724 +3
- Misses 41 42 +1 ☔ View full report in Codecov by Sentry. |
Thanks! |
This is in v2.12.0 |
This is amazing, thanks so much for this! I was going to open a quick PR to support this case for x = measurement.(1:5, 1:5)
y = x .^ 2
errorbars(x, y) but noticed in the tests comments that this case was intentionally left ambiguous. Does this break something upstream if Makie.convert_arguments(P::Type{<:Errorbars}, x::AbstractVector{<:Measurement}, y::AbstractVector{<:Measurement}) =
Makie.convert_arguments(P, value.(x), value.(y), uncertainty.(y)) is added? |
Then again, I guess I'm probably showing my bias by wanting to prefer y errorbars over x errorbars for the default case |
If both |
Right, that's why I was being biased and defaulting to the y direction for right now. Getting both would probably have to be done at the full recipe level, or defining a separate "myerrorbars" function, but idk how general that would be |
Builds on #145
Confirmed that it works for a band and line plot I had around.
Will upload some examples later.
Close #145.