Skip to content

Mascots not saving after update #18

@nahdoubtit

Description

@nahdoubtit

I can confirm bug of mascots resetting after updating, when manually updating to my new version I only picked 'cirno' and then the mascot post update was 'Fubuki Atsuya'. The issue is because of adding or removing mascots, when you do this, it changes the position of the mascot, and the pop up dialog is only saving by location, not actual mascot, for whatever reason. You can reproduce this by using your current base version, hit restore if you deleted any, select, none, then select 'Aquarch Linux' and when updating to my version -> https://github.com/nahdoubtit/OneeChan/raw/master/builds/OneeChan.user.js on refresh you will get Bowsette. This is because the location of the mascots has now changed, and Aquarch Linux is no longer 3rd row, 1st column, but rather 2nd row, 3rd column, and now bowsette has changed to 3rd row, 1st column. To confirm this, again, go back to your base version, pick JC&JS, update to mine, and you will get 'Akaza Akari'. It will do this in reverse if you go from my version to yours. This is a simple fix, in the future, add new mascots to the bottom. This will not affect the location as they are added to the bottom. So there's nothing to fix except how you add mascots, so this issue can be closed.

Your version with two satania links:
current

My version removing the extra satania links:
update

Now with the previous updates you did adding them, I can only assume it did it in reverse, you added Majima after Mikasa Ackerman and before Miyamoto Konatsu, so any mascots select on the 1st or 3rd column after Mikasa, would change spots, and therefore, the update changed the location, which changed the selected mascots.

Metadata

Metadata

Labels

bugSomething isn't workinggood first issueGood for newcomers

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions