Skip to content

Refactor anatomy.cpp for USM and in_order queue#1015

Open
MikeL270 wants to merge 22 commits into
KhronosGroup:mainfrom
MikeL270:buffer-usm-migration
Open

Refactor anatomy.cpp for USM and in_order queue#1015
MikeL270 wants to merge 22 commits into
KhronosGroup:mainfrom
MikeL270:buffer-usm-migration

Conversation

@MikeL270

Copy link
Copy Markdown
  1. Updated anatomy.cpp to use malloc_device. We did not use malloc_shared in order to demonstrate the in_order behavior.
  2. Modified accompanying description to reference the updated code and clarify that the command group scope is created implicitly because of the parallel_for queue shortcut.

Thank you for taking the time to review my pr and do not hesitate to reach out for clarification if needed.

@CLAassistant

CLAassistant commented Jun 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gmlueck

gmlueck commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Please retarget this PR to the "main" branch. Our policy is to make all changes on the "main" branch unless the change is somehow not applicable to future versions of the spec. In this case, the change clearly is applicable to future versions.

Once the PR is merged, I will cherry-pick it to the "sycl-2020" branch if the WG approves it as a SYCL 2020 clarification (which I expect would be the case for this PR).

Comment thread adoc/chapters/architecture.adoc Outdated
Comment thread adoc/chapters/architecture.adoc Outdated
@MikeL270
MikeL270 changed the base branch from sycl-2020 to main June 11, 2026 15:31
@MikeL270

Copy link
Copy Markdown
Author

Please retarget this PR to the "main" branch. Our policy is to make all changes on the "main" branch unless the change is somehow not applicable to future versions of the spec. In this case, the change clearly is applicable to future versions.

Once the PR is merged, I will cherry-pick it to the "sycl-2020" branch if the WG approves it as a SYCL 2020 clarification (which I expect would be the case for this PR).

Done! I will work on addressing the rest of your feedback shortly. Thank you for the guidance!

@TApplencourt
TApplencourt marked this pull request as draft June 11, 2026 19:42
@MikeL270
MikeL270 force-pushed the buffer-usm-migration branch from 381b9d4 to 2c72751 Compare June 11, 2026 20:17
@MikeL270
MikeL270 requested a review from gmlueck June 18, 2026 21:22
@TApplencourt
TApplencourt marked this pull request as ready for review July 2, 2026 16:14
Comment thread adoc/code/anatomy.cpp Outdated

@gmlueck gmlueck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks much improved! Just a few comments below.

Comment thread adoc/chapters/architecture.adoc Outdated
Comment thread adoc/chapters/architecture.adoc Outdated
Comment thread adoc/chapters/architecture.adoc Outdated
Comment thread adoc/chapters/architecture.adoc Outdated
MikeL270 and others added 3 commits July 22, 2026 10:27
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
@MikeL270
MikeL270 requested a review from gmlueck July 22, 2026 15:56
Comment thread adoc/code/anatomy.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants