Refactor anatomy.cpp for USM and in_order queue#1015
Conversation
|
Please retarget this PR to the "main" branch. Our policy is to make all changes on the "main" branch unless the change is somehow not applicable to future versions of the spec. In this case, the change clearly is applicable to future versions. Once the PR is merged, I will cherry-pick it to the "sycl-2020" branch if the WG approves it as a SYCL 2020 clarification (which I expect would be the case for this PR). |
Done! I will work on addressing the rest of your feedback shortly. Thank you for the guidance! |
381b9d4 to
2c72751
Compare
rewrite description of anatomy.cpp
gmlueck
left a comment
There was a problem hiding this comment.
Thanks, this looks much improved! Just a few comments below.
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
anatomy.cppto usemalloc_device. We did not usemalloc_sharedin order to demonstrate the in_order behavior.parallel_forqueue shortcut.Thank you for taking the time to review my pr and do not hesitate to reach out for clarification if needed.