ENH: Build against ITK 5.3-RC3 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbirdso
reviewed
May 2, 2022
| include: | ||
| - itk-python-git-tag: "v5.2.1.post1" | ||
| - itk-python-git-tag: "v5.3rc03" |
There was a problem hiding this comment.
Should these be moved to env variables? See https://github.com/InsightSoftwareConsortium/ITKSplitComponents/blob/master/.github/workflows/build-test-package.yml#L5
There was a problem hiding this comment.
Yes -- these updates are based on ITKModuleTemplate main. Could you please port the ITKSplitComponents updates to ITKModuleTemplate?
There was a problem hiding this comment.
Please see InsightSoftwareConsortium/ITKModuleTemplate#126.
tbirdso
reviewed
May 3, 2022
There was a problem hiding this comment.
May also need to fix the Windows grep path issue, please see https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/pull/126/files#diff-8b27c545141e883b71167a60f61e5a67a8776c84033f7aaf516fd7cafd2b4e02L290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.