Skip to content

Add 'log-requests' option to disable request logging #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

jimmypw
Copy link
Contributor

@jimmypw jimmypw commented Oct 26, 2024

Provide a new command line switch --log-requests that controls weather or not requests to the http handler are logged. I think this is necessary to prevent the application logs from being used as a potential denial of service vector.... I read the log wrong. To prevent the privacy implication of associating IP's with secret retrieval.

By default --log-requests=true and the existing behaviour is maintained. ots will continue to log requests. An administrator may opt in and disable request logging by passing --log-requests=false to ots.

Other logging remains unaffected.

@Luzifer Luzifer changed the title feat: new 'log-requests' option to disable request logging Add 'log-requests' option to disable request logging Oct 26, 2024
@Luzifer Luzifer merged commit 8a21dad into Luzifer:master Oct 26, 2024
4 checks passed
@Luzifer
Copy link
Owner

Luzifer commented Oct 26, 2024

Thanks for the addition. In my case anonymization of IPs is done in another way but for other setups that's a good way to prevent logging PII (and to keep log-spam low for really big instances)…

@Luzifer Luzifer added this to the 1.14.0 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants