MDEV-36808 json_array_intersect incorrect results#5004
Merged
Conversation
grooverdan
added
the
MariaDB Foundation
mariadb-RuchaDeodhar
approved these changes
Apr 29, 2026
mariadb-RuchaDeodhar
left a comment
mariadb-RuchaDeodhar
left a comment
Contributor
There was a problem hiding this comment.
look good. thank you !
grooverdan
enabled auto-merge (rebase)
April 29, 2026 21:15
grooverdan
disabled auto-merge
April 29, 2026 21:48
After JSON_ARRAY_INTERSECT returned a NULL result, within the table scan, all subsequent values where NULL. The checking of null_value in Item_func_json_array_intersect::val_str meant that after the first occurrence of null, all values were null. The purpose of this check started in Item_func_json_array_intersect::prepare_json_and_create_hash where null_value=1 was used to indicate that an object wasn't an array. Replaced to use dedicated is_array boolean. Reviewed by: Rucha Deodhar
grooverdan
enabled auto-merge (rebase)
April 29, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After JSON_ARRAY_INTERSECT returned a NULL result, within the table scan, all subsequent values where NULL.
The checking of null_value in Item_func_json_array_intersect::val_str meant that after the first occurance of null, all values where null.
The purpose of this check started in
Item_func_json_array_intersect::prepare_json_and_create_hash where null_value=1 was used to indicate that an object wasn't an array.