MDEV-40384: innodb_gis.geometry fails on replay#5412
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds "innodb_strict_mode" to the list of optimizer-related system variables in "sql/opt_context_store_replay.cc". It also updates the InnoDB optimizer context replay test and its corresponding result files to record and verify the optimizer context with this new variable included. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
5070945 to
534540a
Compare
Olernov
left a comment
Olernov
left a comment
There was a problem hiding this comment.
LGTM after the cosmetic fix mentioned above
The test had innodb_strict_mode turned OFF, when running the test. But, in the replay, it was enabled, which caused the creation of tables with KEY_BLOCK_SIZE=16 fail. Solution is to record the innodb_strict_mode variable in the context, so that it gets used during the replay.
534540a to
6c97ad6
Compare
6c97ad6
into
bb-12.3-MDEV-39368-test-replay-preview-tree
2 participants
The test had innodb_strict_mode turned OFF, when running the test. But, in the replay, it was enabled, which caused the creation of tables with KEY_BLOCK_SIZE=16 fail.
Solution is to record the innodb_strict_mode variable in the context, so that it gets used during the replay.