[BUG] `M503 C` does not write configuration files to SD card.

[CRCinAU]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When building a firmware with CONFIGURATION_EMBEDDING enabled, the configuration of that firmware is supposed to be written to the SD Card when M503 C is used.

Currently, no configuration files are written to the SD card.

Recv: Cap:CONFIG_EXPORT:1
...
Send: M503 C
Recv: echo:; Linear Units:
Recv: echo:  G21 ; (mm)
...
Send: M22
Recv: echo:SD card released

No files are written to the SD card as expected.

Bug Timeline

No response

Expected behavior

As per documentation:
https://marlinfw.org/docs/gcode/M503.html

[C] 2.0.9.3 CONFIGURATION_EMBEDDING | Save the embedded configuration ZIP file to the SD Card or Flash Drive.

Actual behavior

No files are written.

Steps to Reproduce

No response

Version of Marlin Firmware

bugfix-2.1.x

Printer model

No response

Electronics

No response

Add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

[ellensp]

It's bailing on "if (!dirFile || isOpen()) return false" in Marlin/src/sd/SdBaseFile.cpp

!dirFile is failing and it just returns false.

Basically the directory is not set, and there does not seem to be any code to set a directory.

[ellensp]

Add the failed check else shows that it fails to write, non silently.

if (file.open("mc.zip", O_WRITE|O_CREAT) && file.write(pgm_read_ptr(mc_zip), size) != -1 && file.close())
  SERIAL_ECHO_MSG("Configuration saved as 'mc.zip'");
else
  SERIAL_ECHO_MSG("Couldn't save mc.zip");

[thinkyhead]

Maybe it would work to use file.open(card.getroot(), "mc.zip", O_WRITE|O_CREAT) instead…?

…also adding an #include "../sd/cardreader.h", of course…

[thisiskeithb]

Fixed in 80839cf?

Please download bugfix-2.1.x to test with the latest code and let us know if you're still having this issue.

[ellensp]

Doesn't work. Just created a new compile error

Using default config

enable
EEPROM_SETTINGS
SDSUPPORT
CONFIGURATION_EMBEDDING

add
FORCE_CONFIG_EMBED

compiling errors with

Marlin/src/gcode/eeprom/M500-M504.cpp: In static member function 'static void GcodeSuite::M503()':
Marlin/src/gcode/eeprom/M500-M504.cpp:72:64: error: no matching function for call to 'SdBaseFile::open(MediaFile, const char [7], int)'
         if (file.open(card.getroot(), "mc.zip", O_WRITE|O_CREAT) && file.write(pgm_read_ptr(mc_zip), size) != -1 && file.close())

[CRCinAU]

Seems like a build error now:

Marlin/src/gcode/eeprom/M500-M504.cpp:72:64:
error: no matching function for call to 'SdBaseFile::open(MediaFile, const char [7], int)'

EDIT: hahahah @ellensp beat me to it ;)

[ellensp]

This will build, and creates the file. But the data within is not correct (is not a valid zip file header)

diff --git a/Marlin/src/gcode/eeprom/M500-M504.cpp b/Marlin/src/gcode/eeprom/M500-M504.cpp
index 6da1d1cbd7..94fc36b0a9 100644
--- a/Marlin/src/gcode/eeprom/M500-M504.cpp
+++ b/Marlin/src/gcode/eeprom/M500-M504.cpp
@@ -66,10 +66,10 @@ void GcodeSuite::M502() {
 
     #if ENABLED(CONFIGURATION_EMBEDDING)
       if (parser.seen_test('C')) {
-        SdBaseFile file;
+        MediaFile file, root = card.getroot();
         const uint16_t size = sizeof(mc_zip);
         // Need to create the config size on the SD card
-        if (file.open(card.getroot(), "mc.zip", O_WRITE|O_CREAT) && file.write(pgm_read_ptr(mc_zip), size) != -1 && file.close())
+        if (file.open(&root, "mc.zip", O_WRITE|O_CREAT) && file.write(pgm_read_ptr(mc_zip), size) != -1 && file.close())
           SERIAL_ECHO_MSG("Configuration saved as 'mc.zip'");
       }
     #endif

[thisiskeithb]

Fixed in #25688

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.