[BUG] (not able to compile)

[discip]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I did not change anything.
Just did update to the latest Marlin bugfix-2.1.x

Marlin/src/gcode/bedlevel/G26.cpp: In member function 'bool<unnamed struct>::turn_on_heaters()':
Marlin/src/gcode/bedlevel/G26.cpp:325:12: error: 'class MarlinUI' has no member named 'quick_feedback'
  325 |         ui.quick_feedback();
      |            ^~~~~~~~~~~~~~
Marlin/src/gcode/bedlevel/G26.cpp:342:8: error: 'class MarlinUI' has no member named 'quick_feedback'
  342 |     ui.quick_feedback();
      |        ^~~~~~~~~~~~~~
Marlin/src/gcode/bedlevel/G26.cpp:350:8: error: 'class MarlinUI' has no member named 'completion_feedback'
  350 |     ui.completion_feedback();
      |        ^~~~~~~~~~~~~~~~~~~
Marlin/src/gcode/bedlevel/G26.cpp: In member function 'bool<unnamed struct>::prime_nozzle()':
Marlin/src/gcode/bedlevel/G26.cpp:403:10: error: 'class MarlinUI' has no member named 'quick_feedback'
  403 |       ui.quick_feedback();
      |          ^~~~~~~~~~~~~~
*** [.pio/build/STM32H743Vx_btt/src/src/gcode/bedlevel/G26.cpp.o] Error 1

Bug Timeline

around commit 9a1c025

Expected behavior

Should compile as previously.

Actual behavior

Not compiling!

Steps to Reproduce

1. Update Marlin.
2. Start to compile

Version of Marlin Firmware

91cce2a

Bed Leveling

ABL Bilinear mesh

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration.zip

[ellensp]

code presumes ui.quick_feedbackand and ui.completion_feedback exists

There is also a config issue

#if DISABLED(CLASSIC_JERK)
  #define JUNCTION_DEVIATION_MM 0.4 * sq(DEFAULT_XJERK) / DEFAULT_ACCELERATION // changed [0.4*Jerk²/Accel-print] 0.032 (mm) Distance from real junction edge

but DEFAULT_XJERK is only defined if CLASSIC_JERK is enabled...

[ellensp]

Perhaps the intent was to make these two calls always work, with or without a display, since it has this code, this seems likely. So the fix would be

diff --git a/Marlin/src/lcd/marlinui.h b/Marlin/src/lcd/marlinui.h
index 32d747da43..4c5f7c9bcc 100644
--- a/Marlin/src/lcd/marlinui.h
+++ b/Marlin/src/lcd/marlinui.h
@@ -494,11 +494,6 @@ public:
 
       static void status_screen();
 
-    #else
-
-      static void quick_feedback(const bool=true) {}
-      static void completion_feedback(const bool=true) {}
-
     #endif
 
     #if HAS_MARLINUI_U8GLIB
@@ -526,6 +521,8 @@ public:
 
     static void update() {}
     static void kill_screen(FSTR_P const, FSTR_P const) {}
+    static void quick_feedback(const bool=true) {}
+    static void completion_feedback(const bool=true) {}
 
   #endif

[discip]

@ellensp
Thank you very much for the quick response! 👍🏻

1. There is also a config issue
   ...
   but DEFAULT_XJERK is only defined if CLASSIC_JERK is enabled...

   I know about that, but it was added later on for testing purposes.

2. Or perhaps the intent to to make these two calls always work, with or without a display, since it has this code, this seems more likely. and the code should be

   Are you planing on opening a PR for this?

[ThomasToka]

thats what i reported as i knew it would affect not only my fork #25692

[ellensp]

A PR has been created

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.