[FR] Tronxy X5SA TFT Support on STMF446ZET6 Board

[Pelu88]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I configured all the Configuration.h, Configuration_adv.h and platformio.ini for a Tronxy's board with STM32F446ZET chip. I selected the TFT_TRONXY_X5SA LCD as my screen. When I compile I get this error:

Tool Manager: framework-arduinoststm32@4.10900.200819 has been installed!
Verbose mode can be enabled via -v, --verbose option
In file included from c:\users\manonif\documents\marlin-bugfix-2.1.x-pelu\marlin\src\pins\pins.h:800,
from buildroot/share/PlatformIO/scripts/../../../../Marlin/src/inc/MarlinConfig.h:36,
from buildroot/share/PlatformIO/scripts/common-dependencies.h:29:
c:\users\manonif\documents\marlin-bugfix-2.1.x-pelu\marlin\src\pins\stm32f4/pins_TRONXY_V10.h:190:4: error: #error "TFT_TRONXY_X5SA is not yet supported."
190 | #error "TFT_TRONXY_X5SA is not yet supported."
| ^~~~~
Error: Failed to parse Marlin features. See previous error messages.

I'd like to know which TFT I have to define.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

Marlin-bugfix-2.1.x

Printer model

Tronxy XY3 Pro-V2

Electronics

Stock electronics (STM32F446ZET6)

Add-ons

No response

Bed Leveling

ABL Bilinear mesh

Your Slicer

Prusa Slicer

Host Software

Pronterface

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration files.zip

[EvilGremlin]

It's not a bug, it's feature request. Somweone with skills and hardware have to do this.

[Pelu88]

It's not a bug, it's feature request. Somweone with skills and hardware have to do this.

Sorry I didn't know where to post this, I'm new in this

[jmz52]

@Pelu88, I can work on this, but I have no F446 board to test my code beyond mere compilation.
Will you be able to test it on your printer?

[Pelu88]

@Pelu88, I can work on this, but I have no F446 board to test my code beyond mere compilation. Will you be able to test it on your printer?

Thank you a lot for your time @jmz52 . Yes I can test it for you, I have backup of my current firmware so I would like to test if you find any solution.
Thanks a lot again for contribute

[jmz52]

@Pelu88, F446 code available at https://github.com/jmz52/Marlin/tree/stm32f4-tft-spi-fix
Please note that I had to disable CONTROLLER_FAN_MIN_SOC_TEMP and LIN_ADVANCE features in your configuration files to avoid compilation errors.

[Pelu88]

@Pelu88, F446 code available at https://github.com/jmz52/Marlin/tree/stm32f4-tft-spi-fix Please note that I had to disable CONTROLLER_FAN_MIN_SOC_TEMP and LIN_ADVANCE features in your configuration files to avoid compilation errors.

@jmz52 Alex, I've just downloaded it. I'm seeing it and I have a few questions. Do I have to set the env in platformio don't I? and also I have to configure all the configuration.h and configuration_adv.h? As soon as I can compile and test it I would make you know if it's ok.
Thanks a lot for your time

[jmz52]

Yes, the board-specific changes to platformio.ini and configuration files are not included.
I was using [env:STM32F446_tronxy] build environment and configuration files you've provided.

[Pelu88]

@jmz52 Alex, I've setted up the configuration.h and configuration_adv.h disabling the CONTROLLER_FAN_MIN_SOC_TEMP and LIN_ADVANCE features as you recommended, but I still having compilation errors.
Here it is the terminal debug:

 *  Ejecutando tarea: C:\Users\franc\.platformio\penv\Scripts\platformio.exe run 

Processing STM32F446_tronxy (board: marlin_STM32F446ZET_tronxy; platform: ststm32@~12.1; framework: arduino)
-----------------------------------------------------------------------------------------------------------
Verbose mode can be enabled via `-v, --verbose` option
In file included from d:\compis marlin\marlin-2.1.2.1-gavrilenko\marlin\src\pins\pins.h:800,
                 from d:\compis marlin\marlin-2.1.2.1-gavrilenko\marlin\src\inc\marlinconfig.h:36,
                 from buildroot/share/PlatformIO/scripts/common-dependencies.h:29:
d:\compis marlin\marlin-2.1.2.1-gavrilenko\marlin\src\pins\stm32f4/pins_TRONXY_V10.h:190:4: error: #error "TFT_TRONXY_X5SA is not yet supported."
  190 |   #error "TFT_TRONXY_X5SA is not yet supported."
      |    ^~~~~
Error: Failed to parse Marlin features. See previous error messages.

Then I've tried defining with generic TFT and I get this errors:

In file included from Marlin\src\HAL\STM32\tft\xpt2046.cpp:31:
Marlin\src\HAL\STM32\tft\xpt2046.h:39:4: error: #error "TOUCH_MISO_PIN is not defined."
39 | #error "TOUCH_MISO_PIN is not defined."
| ^~~~~
In file included from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PinNames.h:4,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/pinmap.h:22,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PeripheralPins.h:34,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/analog.h:44,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/board.h:8,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/wiring.h:41,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/Arduino.h:36,
from d:\compis marlin\marlin-2.1.2.1-gavrilenko\marlin\src\hal\shared\marduino.h:36,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/HAL.h:28,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/HAL.h:30,
from Marlin\src\HAL\STM32\tft../../../inc/MarlinConfig.h:33,
from Marlin\src\HAL\STM32\tft\xpt2046.cpp:27:
Marlin\src\HAL\STM32\tft\xpt2046.h: In static member function 'static void XPT2046::dataTransferBegin()':
Marlin\src\HAL\STM32\tft\xpt2046.h:76:87: error: 'TOUCH_CS_PIN' was not declared in this scope; did you mean 'TOUCH_INT_PIN'?
76 | static void dataTransferBegin() { if (SPIx.Instance) { HAL_SPI_Init(&SPIx); } WRITE(TOUCH_CS_PIN, LOW); };
| ^~~~~~~~~~~~
C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PinNamesTypes.h:129:34: note: in definition of macro 'STM_PORT'
129 | #define STM_PORT(X) (((uint32_t)(X) >> 4) & 0xF)
| ^
Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/fastio.h:59:49: note: in expansion of macro 'digitalPinToPinName'
59 | #define _WRITE(IO, V) (FastIOPortMap[STM_PORT(digitalPinToPinName(IO))]->BSRR = _BV32(STM_PIN(digitalPinToPinName(IO)) + ((V) ? 0 : 16)))
| ^~~~~~~~~~~~~~~~~~~
Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/fastio.h:70:33: note: in expansion of macro '_WRITE'
70 | #define WRITE(IO,V) _WRITE(IO,V)
| ^~~~~~
Marlin\src\HAL\STM32\tft\xpt2046.h:76:81: note: in expansion of macro 'WRITE'
76 | static void dataTransferBegin() { if (SPIx.Instance) { HAL_SPI_Init(&SPIx); } WRITE(TOUCH_CS_PIN, LOW); };
| ^~~~~
Marlin\src\HAL\STM32\tft\xpt2046.h: In static member function 'static void XPT2046::dataTransferEnd()':
Marlin\src\HAL\STM32\tft\xpt2046.h:77:41: error: 'TOUCH_CS_PIN' was not declared in this scope; did you mean 'TOUCH_INT_PIN'?
77 | static void dataTransferEnd() { WRITE(TOUCH_CS_PIN, HIGH); };
| ^~~~~~~~~~~~
C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PinNamesTypes.h:129:34: note: in definition of macro 'STM_PORT'
129 | #define STM_PORT(X) (((uint32_t)(X) >> 4) & 0xF)
| ^
Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/fastio.h:59:49: note: in expansion of macro 'digitalPinToPinName'
59 | #define _WRITE(IO, V) (FastIOPortMap[STM_PORT(digitalPinToPinName(IO))]->BSRR = _BV32(STM_PIN(digitalPinToPinName(IO)) + ((V) ? 0 : 16)))
| ^~~~~~~~~~~~~~~~~~~
Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/fastio.h:70:33: note: in expansion of macro '_WRITE'
70 | #define WRITE(IO,V) _WRITE(IO,V)
| ^~~~~~
Marlin\src\HAL\STM32\tft\xpt2046.h:77:35: note: in expansion of macro 'WRITE'
77 | static void dataTransferEnd() { WRITE(TOUCH_CS_PIN, HIGH); };
| ^~~~~
In file included from Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/HAL.h:32,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/HAL.h:30,
from Marlin\src\HAL\STM32\tft../../../inc/MarlinConfig.h:33,
from Marlin\src\HAL\STM32\tft\xpt2046.cpp:27:
Marlin\src\HAL\STM32\tft\xpt2046.cpp: In static member function 'static void XPT2046::init()':
Marlin\src\HAL\STM32\tft\xpt2046.cpp:41:13: error: 'TOUCH_CS_PIN' was not declared in this scope; did you mean 'TOUCH_INT_PIN'?
41 | OUT_WRITE(TOUCH_CS_PIN, HIGH);
| ^~~~~~~~~~~~
Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/fastio.h:67:41: note: in definition of macro '_SET_OUTPUT'
67 | #define _SET_OUTPUT(IO) pinMode(IO, OUTPUT) //!< Output Push Pull Mode & GPIO_NOPULL
| ^~
Marlin\src\HAL\STM32\tft\xpt2046.cpp:41:3: note: in expansion of macro 'OUT_WRITE'
41 | OUT_WRITE(TOUCH_CS_PIN, HIGH);
| ^~~~~~~~~
In file included from Marlin\src\HAL\STM32\tft\tft_fsmc.cpp:31:
Marlin\src\HAL\STM32\tft\tft_fsmc.h:107:12: error: 'FSMC_NORSRAM_DEVICE' was not declared in this scope; did you mean 'FMC_NORSRAM_DEVICE'?
107 | {PD_14, FSMC_NORSRAM_DEVICE, FSMC_PIN_DATA}, // FSMC_D00
| ^~~~~~~~~~~~~~~~~~~
| FMC_NORSRAM_DEVICE
In file included from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PinNames.h:4,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/pinmap.h:22,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PeripheralPins.h:34,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/analog.h:44,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/board.h:8,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/wiring.h:41,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/Arduino.h:36,
from d:\compis marlin\marlin-2.1.2.1-gavrilenko\marlin\src\hal\shared\marduino.h:36,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/HAL.h:28,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/HAL.h:30,
from Marlin\src\HAL\STM32\tft../../../inc/MarlinConfig.h:33,
from Marlin\src\HAL\STM32\tft\tft_fsmc.cpp:27:
Marlin\src\HAL\STM32\tft\tft_fsmc.h:97:69: error: 'GPIO_AF12_FSMC' was not declared in this scope; did you mean 'GPIO_AF12_FMC'?
97 | #define FSMC_PIN_DATA STM_PIN_DATA(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF12_FSMC)
| ^~~~~~~~~~~~~~
C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PinNamesTypes.h:93:29: note: in definition of macro 'STM_PIN_DEFINE'
93 | ((AFNUM & STM_PIN_AFNUM_MASK) << STM_PIN_AFNUM_SHIFT))
| ^~~~~
Marlin\src\HAL\STM32\tft\tft_fsmc.h:97:27: note: in expansion of macro 'STM_PIN_DATA'
97 | #define FSMC_PIN_DATA STM_PIN_DATA(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF12_FSMC)
| ^~~~~~~~~~~~
Marlin\src\HAL\STM32\tft\tft_fsmc.h:107:33: note: in expansion of macro 'FSMC_PIN_DATA'
107 | {PD_14, FSMC_NORSRAM_DEVICE, FSMC_PIN_DATA}, // FSMC_D00
| ^~~~~~~~~~~~~
In file included from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/Arduino.h:56,
from d:\compis marlin\marlin-2.1.2.1-gavrilenko\marlin\src\hal\shared\marduino.h:36,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/HAL.h:28,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/HAL.h:30,
from Marlin\src\HAL\STM32\tft../../../inc/MarlinConfig.h:33,
from Marlin\src\HAL\STM32\tft\xpt2046.cpp:27:
Marlin\src\HAL\STM32\tft\xpt2046.cpp:48:75: error: 'TOUCH_SCK_PIN' was not declared in this scope; did you mean 'TOUCH_INT_PIN'?
48 | spiInstance = (SPI_TypeDef *)pinmap_peripheral(digitalPinToPinName(TOUCH_SCK_PIN), PinMap_SPI_SCLK);
| ^~~~~~~~~~~~~
C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/pins_arduino.h:249:49: note: in definition of macro 'digitalPinToPinName'
249 | #define digitalPinToPinName(p) (((uint32_t)p < NUM_DIGITAL_PINS) ? digitalPin[p] : NC)
| ^
In file included from Marlin\src\HAL\STM32\tft\tft_fsmc.cpp:31:
Marlin\src\HAL\STM32\tft\tft_fsmc.h:108:12: error: 'FSMC_NORSRAM_DEVICE' was not declared in this scope; did you mean 'FMC_NORSRAM_DEVICE'?
108 | {PD_15, FSMC_NORSRAM_DEVICE, FSMC_PIN_DATA}, // FSMC_D01
| ^~~~~~~~~~~~~~~~~~~
| FMC_NORSRAM_DEVICE
compilation terminated due to -fmax-errors=5.
In file included from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PinNames.h:4,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/pinmap.h:22,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PeripheralPins.h:34,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/analog.h:44,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/board.h:8,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/wiring.h:41,
from C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino/Arduino.h:36,
from d:\compis marlin\marlin-2.1.2.1-gavrilenko\marlin\src\hal\shared\marduino.h:36,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/../HAL/STM32/HAL.h:28,
from Marlin\src\HAL\STM32\tft../../../inc/../HAL/HAL.h:30,
from Marlin\src\HAL\STM32\tft../../../inc/MarlinConfig.h:33,
from Marlin\src\HAL\STM32\tft\tft_fsmc.cpp:27:
Marlin\src\HAL\STM32\tft\tft_fsmc.h:97:69: error: 'GPIO_AF12_FSMC' was not declared in this scope; did you mean 'GPIO_AF12_FMC'?
97 | #define FSMC_PIN_DATA STM_PIN_DATA(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF12_FSMC)
| ^~~~~~~~~~~~~~
C:\Users\franc.platformio\packages\framework-arduinoststm32\cores\arduino\stm32/PinNamesTypes.h:93:29: note: in definition of macro 'STM_PIN_DEFINE'
93 | ((AFNUM & STM_PIN_AFNUM_MASK) << STM_PIN_AFNUM_SHIFT))
| ^~~~~
Marlin\src\HAL\STM32\tft\tft_fsmc.h:97:27: note: in expansion of macro 'STM_PIN_DATA'
97 | #define FSMC_PIN_DATA STM_PIN_DATA(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF12_FSMC)
| ^~~~~~~~~~~~
Marlin\src\HAL\STM32\tft\tft_fsmc.h:108:33: note: in expansion of macro 'FSMC_PIN_DATA'
108 | {PD_15, FSMC_NORSRAM_DEVICE, FSMC_PIN_DATA}, // FSMC_D01
| ^~~~~~~~~~~~~
In file included from Marlin\src\HAL\STM32\tft\tft_fsmc.cpp:31:
Marlin\src\HAL\STM32\tft\tft_fsmc.h:109:12: error: 'FSMC_NORSRAM_DEVICE' was not declared in this scope; did you mean 'FMC_NORSRAM_DEVICE'?
109 | {PD_0, FSMC_NORSRAM_DEVICE, FSMC_PIN_DATA}, // FSMC_D02
| ^~~~~~~~~~~~~~~~~~~
| FMC_NORSRAM_DEVICE
compilation terminated due to -fmax-errors=5.
*** [.pio\build\STM32F446_tronxy\src\src\HAL\STM32\tft\xpt2046.cpp.o] Error 1
*** [.pio\build\STM32F446_tronxy\src\src\HAL\STM32\tft\tft_fsmc.cpp.o] Error 1

I don't really know what's happening since I don't know about programming. I'm only trying to set up a Firmware for my machine as the official from Tronxy has an issue with the filament change or ADVANCED_PAUSE_FEATURE which causes the printer to not do the routine as it should.
I re-attached the files that threw these build errors.
Configuration files.zip

[thisiskeithb]

@jmz52: Did you mean to link to https://github.com/jmz52/Marlin/tree/tft-fmc-stm32f446 instead?

[jmz52]

Indeed.
@Pelu88, link I've provided was for another issue.
Please use branch https://github.com/jmz52/Marlin/tree/tft-fmc-stm32f446

[Pelu88]

Indeed. @Pelu88, link I've provided was for another issue. Please use branch https://github.com/jmz52/Marlin/tree/tft-fmc-stm32f446

@jmz52 Downloaded this branch and I could compile it. I flashed and it worked. But, there are some problems with the screen.

As you can see, the middle of the screen is smudged. Not in all menus, but it's random that it appears. If I compile de "Marlin" version provided by Tronxy, I don't have this issue. I don't know if anyone can compare the files, maybe that way can find out where's the problem