add tft calibration screen title and clarify instructions #26200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c624e13 to
e6f1b07
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
9c65146 to
4f65466
Compare
|
breaks TFT_CLASSIC_UI |
|
let try that again |
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c792921 to
37fb26b
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
37d77d6 to
aa44542
Compare
thinkyhead
merged commit 28548ef
into
MarlinFirmware:bugfix-2.1.x
92 of 127 checks passed
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Had a new user trying to setup a MKS TS35 V2.0
Marlin shows them the bootscreen, then this screen
TFT_COLOR_UI
And they had no idea what this screen was about.
From the novice point of view I can see their point, it is very possible they have never seen a touch calibration screen before.
This PR adds a screen tittle to tell the user that this is the touch calibration screen and updated the strings to actually tell them what to do next
TFT_COLOR_UI now looks like this
Clearly announcing that they are looking at the "Touch Screen Calibration" and telling them what do do next
Requirements
Marlin directly controlled TFT display with touch such as a mks TS35 V2.0
Benefits
Less confused users, hopefully.
Configurations