-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
🔨 Rename FYSETC S6/Spider Environments #27122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Rename FYSETC S6/Spider Environments #27122
Conversation
bc82e9d
to
ad1a6b9
Compare
ad1a6b9
to
f1eec11
Compare
opt_set Y_DRIVER_TYPE TMC2209 Z_DRIVER_TYPE TMC2130 | ||
opt_set MOTHERBOARD BOARD_FYSETC_S6_V2_0 SERIAL_PORT -1 BAUDRATE 115200 TEMP_SENSOR_BED 0 \ | ||
DEFAULT_AXIS_STEPS_PER_UNIT '{ 80, 80, 400, 400 }' Y_DRIVER_TYPE TMC2209 Z_DRIVER_TYPE TMC2130 | ||
opt_enable MEATPACK_ON_SERIAL_PORT_1 EEPROM_SETTINGS SDSUPPORT | ||
exec_test $1 $2 "FYSETC S6 Example" "$3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MEATPACK_ON_SERIAL_PORT_1
is about the only useful part of this test, so it can likely be merged into another test & then this test can be completely removed to speed up CI checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to consolidate and remove tests. What we basically need is just one test for each HAL to make sure the features of the HAL compile. Those tests can maximize the number of enabled features but also differ from one another. If we wanted to test all LCDs we would pick the platform that supports the most LCDs and add a test for each LCD that isn't already tested under some other platform, with a multitude of features enabled. IOW, tests may be completely rebuilt from the ground up.
f1eec11
to
6a37dcf
Compare
c792921
to
37fb26b
Compare
6a37dcf
to
84826fd
Compare
37d77d6
to
aa44542
Compare
84826fd
to
1350d2a
Compare
1350d2a
to
a77991e
Compare
In preparation for removing this *super basic* board config.
a77991e
to
783f355
Compare
Description
This is a precursor PR in preparation for additional Spider board support. Figured I'd break out these changes since there was already a lot going on.
STM32F446VE_fysetc
environment from the Spider V2.2 since all Spider boards manufactured after 2021/06/23 (V2.2+) use the smaller 32k bootloader.S6 config diffed on top of default config:
Note:
Z_STEPPER_ALIGN_ITERATIONS
was not included in standalone test due toZ_STEPPER_AUTO_ALIGN
being disabled in the config.Smaller Bootloader Info & Sources: