Skip to content

🔨 Rename FYSETC S6/Spider Environments #27122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented May 23, 2024

Description

This is a precursor PR in preparation for additional Spider board support. Figured I'd break out these changes since there was already a lot going on.

  • Rename/generalize FYSETC S6/Spider environments.
  • Dropped STM32F446VE_fysetc environment from the Spider V2.2 since all Spider boards manufactured after 2021/06/23 (V2.2+) use the smaller 32k bootloader.
  • S6 and Spider boards ship with an STM32F446VET6 MCU, so I corrected the variant info.
  • Rename FYSETC S6 test & moved over the generic S6 board config to make the test standalone in preparation for config removal. We don't maintain generic board configs / they need to be customized for a specific machine and this config is extremely basic:
S6 config diffed on top of default config:

diff --git a/config/examples/FYSETC/S6/Configuration.h b/config/examples/FYSETC/S6/Configuration.h
index ea14b9d..cca8f52 100644
--- a/config/examples/FYSETC/S6/Configuration.h
+++ b/config/examples/FYSETC/S6/Configuration.h
@@ -21,6 +21,8 @@
  */
 #pragma once
 
+#define CONFIG_EXAMPLES_DIR "FYSETC/S6"
+
 /**
  * Configuration.h
  *
@@ -68,7 +70,7 @@
 
 // Choose the name from boards.h that matches your setup
 #ifndef MOTHERBOARD
-  #define MOTHERBOARD BOARD_RAMPS_14_EFB
+  #define MOTHERBOARD BOARD_FYSETC_S6
 #endif
 
 /**
@@ -79,7 +81,7 @@
  *
  * :[-1, 0, 1, 2, 3, 4, 5, 6, 7]
  */
-#define SERIAL_PORT 0
+#define SERIAL_PORT -1
 
 /**
  * Serial Port Baud Rate
@@ -92,7 +94,7 @@
  *
  * :[2400, 9600, 19200, 38400, 57600, 115200, 250000, 500000, 1000000]
  */
-#define BAUDRATE 250000
+#define BAUDRATE 115200
 
 //#define BAUD_RATE_GCODE     // Enable G-code M575 to set the baud rate
 
@@ -570,7 +572,7 @@
 #define TEMP_SENSOR_5 0
 #define TEMP_SENSOR_6 0
 #define TEMP_SENSOR_7 0
-#define TEMP_SENSOR_BED 1
+#define TEMP_SENSOR_BED 0
 #define TEMP_SENSOR_PROBE 0
 #define TEMP_SENSOR_CHAMBER 0
 #define TEMP_SENSOR_COOLER 0
@@ -1245,7 +1247,7 @@
  * Override with M92 (when enabled below)
  *                                      X, Y, Z [, I [, J [, K...]]], E0 [, E1[, E2...]]
  */
-#define DEFAULT_AXIS_STEPS_PER_UNIT   { 80, 80, 400, 500 }
+#define DEFAULT_AXIS_STEPS_PER_UNIT   { 80, 80, 400, 400 }
 
 /**
  * Enable support for M92. Disable to save at least ~530 bytes of flash.
@@ -2379,7 +2381,7 @@
  *   M501 - Read settings from EEPROM. (i.e., Throw away unsaved changes)
  *   M502 - Revert settings to "factory" defaults. (Follow with M500 to init the EEPROM.)
  */
-//#define EEPROM_SETTINGS     // Persistent storage with M500 and M501
+#define EEPROM_SETTINGS       // Persistent storage with M500 and M501
 //#define DISABLE_M503        // Saves ~2700 bytes of flash. Disable for release!
 #define EEPROM_CHITCHAT       // Give feedback on EEPROM commands. Disable to save flash.
 #define EEPROM_BOOT_SILENT    // Keep M503 quiet and only give errors during first load
@@ -2669,7 +2671,7 @@
  * SD Card support is disabled by default. If your controller has an SD slot,
  * you must uncomment the following option or it won't work.
  */
-//#define SDSUPPORT
+#define SDSUPPORT
 
 /**
  * SD CARD: ENABLE CRC
diff --git a/config/examples/FYSETC/S6/Configuration_adv.h b/config/examples/FYSETC/S6/Configuration_adv.h
index 68646ba..357aca0 100644
--- a/config/examples/FYSETC/S6/Configuration_adv.h
+++ b/config/examples/FYSETC/S6/Configuration_adv.h
@@ -21,6 +21,8 @@
  */
 #pragma once
 
+#define CONFIG_EXAMPLES_DIR "FYSETC/S6"
+
 /**
  * Configuration_adv.h
  *
@@ -1071,7 +1073,7 @@
 
   // On a 300mm bed a 5% grade would give a misalignment of ~1.5cm
   #define G34_MAX_GRADE              5    // (%) Maximum incline that G34 will handle
-  #define Z_STEPPER_ALIGN_ITERATIONS 5    // Number of iterations to apply during alignment
+  #define Z_STEPPER_ALIGN_ITERATIONS 3    // Number of iterations to apply during alignment
   #define Z_STEPPER_ALIGN_ACC        0.02 // Stop iterating early if the accuracy is better than this
   #define RESTORE_LEVELING_AFTER_G34      // Restore leveling after G34 is done?
   // After G34, re-home Z (G28 Z) or just calculate it from the last probe heights?

Note: Z_STEPPER_ALIGN_ITERATIONS was not included in standalone test due to Z_STEPPER_AUTO_ALIGN being disabled in the config.


Smaller Bootloader Info & Sources:

opt_set Y_DRIVER_TYPE TMC2209 Z_DRIVER_TYPE TMC2130
opt_set MOTHERBOARD BOARD_FYSETC_S6_V2_0 SERIAL_PORT -1 BAUDRATE 115200 TEMP_SENSOR_BED 0 \
DEFAULT_AXIS_STEPS_PER_UNIT '{ 80, 80, 400, 400 }' Y_DRIVER_TYPE TMC2209 Z_DRIVER_TYPE TMC2130
opt_enable MEATPACK_ON_SERIAL_PORT_1 EEPROM_SETTINGS SDSUPPORT
exec_test $1 $2 "FYSETC S6 Example" "$3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEATPACK_ON_SERIAL_PORT_1 is about the only useful part of this test, so it can likely be merged into another test & then this test can be completely removed to speed up CI checks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to consolidate and remove tests. What we basically need is just one test for each HAL to make sure the features of the HAL compile. Those tests can maximize the number of enabled features but also differ from one another. If we wanted to test all LCDs we would pick the platform that supports the most LCDs and add a test for each LCD that isn't already tested under some other platform, with a multitude of features enabled. IOW, tests may be completely rebuilt from the ground up.

@thisiskeithb thisiskeithb force-pushed the pr/rename_fysetc_s6_envs branch from f1eec11 to 6a37dcf Compare July 30, 2024 03:17
@thisiskeithb thisiskeithb force-pushed the pr/rename_fysetc_s6_envs branch from 6a37dcf to 84826fd Compare September 6, 2024 01:36
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 37d77d6 to aa44542 Compare September 28, 2024 01:10
@thisiskeithb thisiskeithb force-pushed the pr/rename_fysetc_s6_envs branch from 84826fd to 1350d2a Compare October 19, 2024 13:08
@thisiskeithb thisiskeithb force-pushed the pr/rename_fysetc_s6_envs branch from 1350d2a to a77991e Compare November 3, 2024 16:25
In preparation for removing this *super basic* board config.
@thisiskeithb thisiskeithb force-pushed the pr/rename_fysetc_s6_envs branch from a77991e to 783f355 Compare January 12, 2025 22:54
@thinkyhead thinkyhead merged commit 78f8715 into MarlinFirmware:bugfix-2.1.x Mar 14, 2025
64 checks passed
@thisiskeithb thisiskeithb deleted the pr/rename_fysetc_s6_envs branch March 14, 2025 21:42
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants