Skip to content

Switch to Static asserts to allow use of floats on DUAL_X_CARRIAGE configurations #27701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2025

Conversation

Farva42
Copy link
Contributor

@Farva42 Farva42 commented Feb 21, 2025

Description

This will allow Floats to be used for X2_MAX_POS, X2_HOME_POS, X1_MIN_POS & X1_MAX_POS on DUAL_X_CARRIAGE configurations.
I also removed a redundant check on the X2_MAX_POS and replaced with a check to avoid the X2 hitting X1 while X1 is parked.

Requirements

Tested using the configuration from the below Issue

Benefits

Allows for using Floats when using DUAL_X_CARRIAGE

Configurations

configuration.zip

Related Issues

(#27623)

… & include test to insure X2 cannot hit X1 in the parked position.
@Farva42
Copy link
Contributor Author

Farva42 commented Feb 21, 2025

CI tests failing in setup

E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/libs/libsndfile/libsndfile1_1.0.31-2ubuntu0.1_amd64.deb 404 Not Found [IP: 52.147.219.192 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@thinkyhead
Copy link
Member

thinkyhead commented Mar 1, 2025

The home position settings are still recommended to just be integers, as endstops aren't considered precise enough to align below 1mm. For precision in aligning the two hotends for multi-material printing, use M218.

@thinkyhead thinkyhead force-pushed the Float_test branch 2 times, most recently from 72b8ff4 to d6ff635 Compare March 1, 2025 04:25
@thinkyhead thinkyhead merged commit dd3bf29 into MarlinFirmware:bugfix-2.1.x Mar 1, 2025
64 checks passed
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants