Add spindle acceleration #27759
Merged
Add spindle acceleration #27759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
DerAndere1
force-pushed
the
spindle_acceleration
branch
2 times, most recently
from
80aa324 to
e2b3412
Compare
DerAndere1
force-pushed
the
spindle_acceleration
branch
from
e2b3412 to
3391e9d
Compare
buergi
previously requested changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for your implementation. Unfortunately it does not work like that, the most problematic part is the while loop inside _set_ocr() which blocks the whole firmware. Maybe something like the planner is needed to perform periodic update of the spindle speed.
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
4354891 to
efa1758
Compare
thinkyhead
force-pushed
the
spindle_acceleration
branch
from
5c444b8 to
51af38a
Compare
DerAndere1
force-pushed
the
spindle_acceleration
branch
from
740236e to
6429897
Compare
DerAndere1
force-pushed
the
spindle_acceleration
branch
from
be7d395 to
a6baca6
Compare
|
Thanks for the help with this one, guys. I will keep this in draft mode until it was tested on hardware. |
thinkyhead
force-pushed
the
spindle_acceleration
branch
from
1ea905d to
c8824f5
Compare
thinkyhead
force-pushed
the
spindle_acceleration
branch
from
034ed5d to
23eb1c8
Compare
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Apr 14, 2025
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instantaneous changes to the spindle PWM duty cycle during M3/M4 commands can cause voltage fluctuations and reconfiguration of stepper drivers. This PR adds the setting
DEFAULT_ACCELERATION_SPINDLE. When this option is enabled together with SPINDLE_LASER_USE_PWM, the spindle is accelerated slowly.Changes that would allow setting spindle acceleration at runtime via
M201 T0are not part of this PR because that would require merging of PR #27614Requirements
SPINDLE_FEATURE,SPINDLE_LASER_USE_PWMBenefits
linear spindle acceleration instead of instantaneous PWM duty cycle changes.
fixes #27727
Configurations
This PR contains a seperate commit that updates the config. Default behaviour remainsunchanged (instantaneous PWM change). For testing the new behaviour, enable and set
DEFAULT_ACCELERATION_SPINDLE. Also enableSPINDLE_FEATURE,SPINDLE_LASER_USE_PWMRelated Issues
#27727