Skip to content

Native GD32 support for Aquila v1.0.1 #27765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 7, 2025

Conversation

bmourit
Copy link
Contributor

@bmourit bmourit commented Mar 28, 2025

Description

This adds support for Aquila v1.0.1 boards that shipped with GD32F103RC

Requirements

None

Benefits

This extends the GD32 native support to Aquila v1.0.1 GD32F103RC boards

Configurations

Configuration changes are similar to Creality v4.2.2 MFL. Serial port is 0 instead of 1

@bmourit
Copy link
Contributor Author

bmourit commented Mar 30, 2025

Just wanted to mention as well. It was also linked in with the original platform support of GD32 but I think it just got missed. We need the changes of the PR I made in the u8glib repo in order to be able to actually compile and use the default LCD. Should I make a bug report here? I did everything in that repo itself.

@thinkyhead thinkyhead added C: Boards/Pins T: HAL & APIs Topic related to the HAL and internal APIs. labels Apr 1, 2025
@Nuck-TH
Copy link

Nuck-TH commented Apr 2, 2025

I think page should be taken from structure of ini for stm32 - there should be separate sections for MCUs with mcu specific parameters and compiler flags/defines, and boards should extend them with board-specific things.

@bmourit
Copy link
Contributor Author

bmourit commented Apr 2, 2025

I think page should be taken from structure of ini for stm32 - there should be separate sections for MCUs with mcu specific parameters and compiler flags/defines, and boards should extend them with board-specific things.

I'm fine with however it is done. It is a little different than the maple environment though since that is still the same MCU target whereas this is a different one. This one wont build or support the STM32, so it isn't interchangable like Maple. I do agree though that sharing as much as possible is ideal, so long as it is clear to the user. Marlin has done an excellent job with that so for, so however it is decided I fully support. :)

The chip shortage really made this messy though, with boards of the same printer/version shipped randomly with GD32/STM32/HC32 etc. A somewhat unique situation.

I suspect anything like that will likely be after the 2.1.3 release though, since it is already in beta.

EDIT:
I just re-read you comment. As far as the gd32.ini goes, we could do that. If we do plan to eventually add most/all boards then this may be useful. With only 2 boards as of right now, it just seemed a little overkill. But again, I'm fine with either.

@thinkyhead thinkyhead merged commit bdc0bd0 into MarlinFirmware:bugfix-2.1.x Apr 7, 2025
68 checks passed
@bmourit bmourit deleted the board_pr branch April 24, 2025 16:48
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Boards/Pins T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants