Fix warnings with GCC14 and C++23 #27768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified left operand is deprecated [-Wvolatile]' from planner when using GCC 14 and C++23 and remove suppression flags from .ini file
|
Too bad we can't specify warning flags just for certain headers and source files without adding separate linker steps. The main thing, ultimately, is to get a reasonable optimized binary for release and a debuggable binary for development. In general this old schooner is holding together well, and the next slate of refactors will continue to raise it up a bit more…. |
thinkyhead
pushed a commit
that referenced
this pull request
Apr 1, 2025
|
Yes I agree. It is an Arduino warning anyway for their preference binary literals. It is the only warning though, and Marlin was very clean! |
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes two warnings found in the planner.h/.cpp code when building using GCC14 and C++23. Also removed the flag to suppress the warning for the GD32 MFL platform.
Note:
Unfortunately, GD32 still needs to suppress deprecated warnings due to the latest Arduino API (Binary.h) causing spam with C++14 and later and not using binary literals. However, changing to binary literals in Marlin would break building with older compilers and other platforms.
Requirements
None
Benefits
No build warnings.
Related Issues
Fixes #27767