-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
Add virtual servos and bltouch support to the simulator #27779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual servos and bltouch support to the simulator #27779
Conversation
Love this! |
cant wait to see this merge |
here are some changes i had to make to get it to compile:
#if !NEED_HIT_STATE(Z_MIN)
//#undef Z_MIN_ENDSTOP_HIT_STATE
#endif
#if !NEED_HIT_STATE(Z_MAX)
//#undef Z_MAX_ENDSTOP_HIT_STATE
#endif I suppose the |
ENDSTOP_INTERRUPTS_FEATURE is not part of https://github.com/MarlinFirmware/Configurations/tree/bugfix-2.1.x/config/examples/Simulator and its is not supported in the sim. No changes are required with standard configs |
I was able to use basically an Ender-3 V2 config with DWIN lcd and it works. what about software interrupts |
This emulator is one of the most under appreciated, but incredibly useful parts of Marlin, IMH. This added virtual servo support support is awesome. |
Just make sure this isn't merged early, changes are still being worked through in the simulator channel on Discord and I assume those will go upstream to @p3p's repo once that is all worked out. |
No worries. This will not be merged until |
Bltouch Looks good, tested homing and probing a 10x10 UBL Currently breaks building if you enabled servos but not a bltouch. |
I think we are all good to go, just waiting on p3p/MarlinSimUI#49 so can change native.ini back to p3p from my fork. Now with a nice Bltouch menu thanks to p3p |
This is a great bottle example of how to add new functionality to the Simulator! I'll be sure to put it on the list of examples for new developers in the Developer Guide, along with any other well-contained PRs that exemplify how to do a thing. |
p3p MarlinSimUI has been updated, and ini/native.ini has been updated to use it. |
Co-authored-by: Christopher Pepper <[email protected]>
Description
This adds virtual servos to the Simulator.
It does not simulate the PWM signals on the pins, It just provides a mostly stub servo library.
This allows us to run bltouch code in the simulator.
Requirements
run the simulator + servos, includes bltouch
Benefits
Bltouch and servo support!!!
Configurations
Standard https://github.com/MarlinFirmware/Configurations/tree/bugfix-2.1.x/config/examples/Simulator + bltouch enabled
Notes
This requires a patch to the MarlinSimUI, so for review I have updated native.ini to point to my fork.
A PR to update MarlinSimUI is in thee works p3p/MarlinSimUI#49
I have set this to draft until MarlinSimUI is updated.