MKS_H43 : Fix #27788 #27789
Merged
MKS_H43 : Fix #27788 #27789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
thinkyhead
reviewed
Apr 13, 2025
| @@ -326,7 +326,7 @@ void DGUSScreenHandler::sendHeaterStatusToDisplay(DGUS_VP_Variable &var) { | |||
| void DGUSScreenHandler::sdCardError() { | |||
| DGUSScreenHandler::sdCardRemoved(); | |||
| #if DGUS_LCD_UI_MKS | |||
| sendInfoScreenMKS(F("NOTICE"), nullptr, F("SD card error"), nullptr, mks_language_index); | |||
| screen.sendInfoScreenMKS(F("NOTICE"), nullptr, F("SD card error"), nullptr, mks_language_index); | |||
| #else | |||
| sendInfoScreen(F("NOTICE"), nullptr, F("SD card error"), nullptr); | |||
| #endif | |||
There was a problem hiding this comment.
I plan to properly refactor this Screen Handler API so this kind of hack is not required. Stay tuned.
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug was introduced in last MKS_H43 rework commit. This PR fixes it.
Requirements
Benefits
Configurations
Related Issues