GD32: Fix Serial DMA not honoring the SERIAL_DMA flag #27800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibrary, regardless of the marlin SERIAL_DMA flag. Leading to undefined behavior. We now call the provided beginoverload function from Arduino core and pass a bool parameter to enable DMA on the Rx pin.
bmourit
changed the title
bmourit
changed the title
This was referenced Apr 17, 2025
thinkyhead
added
PR: Bug Fix
C: Peripherals
T: HAL & APIs
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the GD32 serial DMA always being enabled in the Arduino Core library regardless of the marlin SERIAL_DMA flag. We now call the provided "begin" overload function from the Arduino core and pass a bool parameter to enable DMA on the Rx pin.
Requirements
Requires #27801
Supported GD32 board.
Benefits
Fixes an issue that could cause unexpected and unhandled interrupts when SERIAL_DMA is disabled in Marlin.
Related Issues
None.