-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
MKS UI - Fix G-code command result display #27825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MKS UI - Fix G-code command result display #27825
Conversation
7ab6c00
to
005f031
Compare
@@ -160,7 +160,7 @@ static void lv_kb_event_cb(lv_obj_t *kb, lv_event_t event) { | |||
goto_previous_ui(); | |||
break; | |||
case GCodeCommand: | |||
if (ret_ta_txt[0] && !queue.ring_buffer.full(3)) { | |||
if (ret_ta_txt[0] && !queue.ring_buffer.full(BUFSIZE - 1)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would require the buffer to have no more than 1 command in it, but we probably want to allow for the buffer to have more things.
Meanwhile, there may be a fundamental misunderstanding from Makerbase about how queue.inject
works. It doesn't put anything into the G-code buffer right away. It sets up commands that will be injected before the regular G-code buffer. So it doesn't matter here if the buffer is "full" or "close to full" or not! The commands will be run before the next command(s) in the queue.
2f32005
to
5484443
Compare
Thanks for the fix! We want to continue to improve our support for this MKS display and extend support for this display to all boards. The first step is #25650 which will follow the 2.1.3 release. The only refactor work required to modernize the MKS UI code and make this display compatible with old-school AVR is to fix all the code that handles static data so that it stores and retrieves via PROGMEM, and to use |
Co-authored-by: Scott Lahteine <[email protected]>
Description
The serial port hook gcode command result takes time to complete, so it is added to the UI refresh queue.
CC: @makerbase-mks @MKS-Sean