Improve removing unused TEMP_SENSOR definitions #27826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellensp
changed the title
|
Looks ok! I was initially worried that |
thinkyhead
force-pushed
the
Improve-Clean-up-unused-temperature-sensors
branch
from
7f9df06 to
d244533
Compare
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noticed that unused erroneous TEMP_SENSOR_[N] defines where not being removed.
In most cases this doesn't cause issue, but thermistor type 66 has sanity checks that break building, there are probably others.
So I improved the conditionals that remove unused TEMP_SENSOR_[N] defines to also check for a hotend.
Benefits
Less unused defines.
Note
This should be considered for other branches also. (the person who brought this to my attention was using 2.1.2.5)